Both assertHeaderExists functions now behave in the same way.

[rbudzko]

While not sure if it is a desired behavior, I'd like to propose such a change 😇 .

[akka-ci]

Can one of the repo owners verify this patch?

[rbudzko]

BTW, it's #5.

[ktoso]

This does not solve #5 though? I was about making the error message show what headers were available in addition to saying what was missing.

[ktoso]

OK TO TEST

[akka-ci]

Test PASSed.

[rbudzko]

This does not solve #5 though? I was about making the error message show what headers were available in addition to saying what was missing.

Another assertHeaderExists (called inside) is stating that header was missing or that it was present but none of given values was compliant with the assertion: header was found but had the wrong value. Found headers: ${headers.mkString(", ")}").

[ktoso]

Please mention such things in PRs ;) It's non obvious to see from the changes made that now it's supposed to work as intended

[ktoso]

LGTM

[rbudzko]

Please mention such things in PRs ;) It's non obvious to see from the changes made that now it's supposed to work as intended

Uh, sorry. Will do in future.

[jypma]

Thanks for the PR! Even more important than the PR text is the commit message. If it resolves #5, mention it in the message. And be specific: rather than saying "in the same way", explain what that way is.

That way, anyone browsing the code at a future point in time can immediately see the intentions, without having to do further digging.

[akka-ci]

Test PASSed.

[akka-ci]

Test PASSed.

[rbudzko]

Thanks for the feedback! I've improved the commit message.

[jypma]

Commit message now has a typo (too many 's' in 'missing') :)

And "misssing header name or values not matching assertion are not logged"? Isn't the whole point that they now are logged?

[rbudzko]

Pardon my absentmindedness...

[jrudolph]

Thanks @rbudzko. Great change.

[akka-ci]

Test FAILed.

[jypma]

[info]   - the config setting (chunked entity) *** FAILED ***
[info]     null did not equal EntityStreamSizeException: actual entity size (None) exceeded content length limit (10 bytes)! You can configure this by setting `akka.http.[server|client].parsing.max-content-length` or calling `HttpEntity.withSizeLimit` before materializing the dataBytes stream.,
[info]     inside HttpResponse(200 OK,List(),HttpEntity.Chunked(application/octet-stream),HttpProtocol(HTTP/1.1)) (LowLevelOutgoingConnectionSpec.scala:564)

is that even related to the change?

[jrudolph]

This was intentional. Otherwise, the function given to the filter will call name.toRootLowerCase for every header during the iteration.

[jrudolph]

Could you remove the braces? Thanks ;)

[akka-ci]

Test PASSed.

[aruediger]

Looks good @rbudzko! I'd kepp the first line short:

assertHeaderExists functions now behave in the same way  (#5)
information about missing header name or values not matching assertion are logged.

But we can fix that while merging.

@akka/akka-http-team Do we have a policy re. commit msgs yet?

[jrudolph]

@akka/akka-http-team Do we have a policy re. commit msgs yet?

I'd say we try to keep the akka one for consistency.

[aruediger]

Thx @rbudzko!

[aruediger]

I'd say we try to keep the akka one for consistency.

see akka/akka-meta#30