Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MdcLoggingDirectives (withMdcLogging, withMdcEntry, withMdcEntries, extractMarkerLog) #3974

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

MdcLoggingDirectives (withMdcLogging, withMdcEntry, withMdcEntries, extractMarkerLog) #3974

wants to merge 10 commits into from

Commits on Dec 21, 2021

  1. First pass at MdcLoggingDirectives (Scala only)

    @alexklibisz
    alexklibisz committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    65eb272 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Rearrange methods to get rid of .asInstanceOf

    @alexklibisz
    alexklibisz committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    629938f View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Move .tool-versions to .git/info/exclude

    @alexklibisz
    alexklibisz committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    6f6c4e0 View commit details
    Browse the repository at this point in the history

  2. Use withMdcLogging & extractDiagnosticMarkerLog where possible

    @alexklibisz
    alexklibisz committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    d434e00 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. Every directive call creates a new adapter to avoid race conditions 

    - All MDC directives create a new MarkerLoggingAdapter to avoid race conditions.
- Combined withMdcLogging and extractMarkerLog into a single directive withMarkerLoggingAdapter.
- Updated tests to account for the expectation that ever call to a directive creates a new logging adapter.
- Added a test using the EventFilter to verify that the entries are actually being attached.
    @alexklibisz
    alexklibisz committed May 14, 2022
    Configuration menu
    Copy the full SHA
    776f4ef View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2022

  1. Merge remote-tracking branch 'origin/main' into mdc-logging-directives

    @alexklibisz
    alexklibisz committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    c652021 View commit details
    Browse the repository at this point in the history

  2. Add a case for converting an instance of BusLogging to DiagnosticMark… 

    …erBusLoggingAdapter

- Based on suggestion here: https://github.com/akka/akka-http/pull/3974/files/776f4ef37bec392a9afa96ccd10a9b1d64660c9b#r875025973
- This is not yet adequately tested.
- Had to slightly tweak a test because behavior of EventFilter seems to have changed.
    @alexklibisz
    alexklibisz committed Dec 26, 2022
    Configuration menu
    Copy the full SHA
    d0ac46e View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Merge remote-tracking branch 'origin/main' into mdc-logging-directives

    @alexklibisz
    alexklibisz committed May 30, 2023
    Configuration menu
    Copy the full SHA
    efb56e0 View commit details
    Browse the repository at this point in the history

  2. Get tests to compile on 2.12

    @alexklibisz
    alexklibisz committed May 30, 2023
    Configuration menu
    Copy the full SHA
    e2f0da6 View commit details
    Browse the repository at this point in the history

  3. Use custom EventFilter class with @volatile buffer to fix test race c… 

    …ondition
    @alexklibisz
    alexklibisz committed May 30, 2023
    Configuration menu
    Copy the full SHA
    17c6540 View commit details
    Browse the repository at this point in the history