Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: make sure to document needed implicits #18021

Closed
rkuhn opened this issue Jul 17, 2015 · 3 comments
Closed

DOCS: make sure to document needed implicits #18021

rkuhn opened this issue Jul 17, 2015 · 3 comments

Comments

@rkuhn
Copy link
Contributor

rkuhn commented Jul 17, 2015

From the mailing list:

I got hit by this stuff today when moving some tests from one package to another disabled responseAs[String] completely (earlier, it worked in some endpoints, but not in others). The answer is to import akka.http.scaladsl.unmarshalling.Unmarshaller._ in tests, which mixes in PredefinedFromEntityUnmarshallers, which contain an unmarshaller to string. Second, it is necessary to import akka.http.scaladsl.marshalling.Marshaller._ in the file where the route is defined, so that string responses are marshalled correctly (if you don't do it, your response bodies unmarshalled in tests will contain an extra set of double quotes).

@rkuhn rkuhn added this to the http-1.1 milestone Jul 17, 2015
@rkuhn rkuhn added 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding t:docs t:http:next labels Jul 17, 2015
@drewhk
Copy link
Contributor

drewhk commented Aug 25, 2015

Maybe add one dedicated section too, kind of an "imports cheat-sheet"? I also have to sometimes look into the akka-http tests to remember what imports I will need and which I don't, implicits or simply model entities :)

@patriknw
Copy link
Member

+1

@ktoso ktoso modified the milestones: http-2.0-M1, http-2.0-M2 Nov 6, 2015
@ktoso ktoso modified the milestones: http-2.0-M2, http-2.0 Nov 30, 2015
@ktoso ktoso modified the milestones: http-2.0, http-backlog Dec 21, 2015
ktoso pushed a commit to ktoso/akka that referenced this issue Jan 11, 2016
ktoso pushed a commit to ktoso/akka that referenced this issue Jan 11, 2016
@rkuhn rkuhn removed the 2 - pick next Used to mark issues which are next up in the queue to be worked on. The tag is non-binding label Jan 14, 2016
@rkuhn rkuhn modified the milestones: 2.4.2, stream-http-master Jan 24, 2016
@rkuhn rkuhn added the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label Jan 24, 2016
@johanandren johanandren modified the milestones: 2.4.7, 2.4.6 May 19, 2016
@johanandren johanandren modified the milestones: 2.4.7, 2.4.8 Jun 3, 2016
@ktoso ktoso modified the milestones: 2.4.8, 2.4.9 Jul 8, 2016
@ktoso ktoso modified the milestones: 2.4.9-RC1, 2.4.9, 2.4.9-RC2 Aug 2, 2016
@johanandren johanandren modified the milestones: 2.4.9, 2.4.10 Aug 19, 2016
@2m 2m modified the milestones: 2.4.10, 2.4.11 Sep 7, 2016
@ktoso ktoso removed the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label Sep 8, 2016
@ktoso
Copy link
Contributor

ktoso commented Sep 12, 2016

Ticket moved to github.com/akka/akka-http
 (direct link to new issue visible on github just above this comment). Rationale for the move discussed here: akka/akka-meta#27

If you are interested in contributing or tracking this issue, please comment in akka-http instead from now on :-)

@ktoso ktoso closed this as completed Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants