Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseByteArrayJournalDao lacks resiliency against stream failure #497

Open
Arkatufus opened this issue Dec 6, 2024 · 1 comment
Open

Comments

@Arkatufus
Copy link
Contributor

Arkatufus commented Dec 6, 2024

BaseByteArrayJournalDao does not check to see if any of the streams it uses failed/completed/terminated, causing the journal to fail with no way of recovering, the only way to recover is to restart the node.

Chain of event:
image

image

image

@Arkatufus
Copy link
Contributor Author

Possible scenario:

  1. An exception/failure/timeout happened inside the SelectAsync() stage while a write was happening, stopping the stream (first figure).
  2. The exception did not get propagated, causing an NRE to happen when it is being propagated up the stream (second figure).
  3. The journal was not aware that the stream has stopped and failed to restart either itself or the stream, poisoning the persistence system (third figure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant