-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analyzer and fixer for (AK1002) Must not await GracefulStop() inside ReceiveAsync #58
Add analyzer and fixer for (AK1002) Must not await GracefulStop() inside ReceiveAsync #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only question I have is on the code fix - see comments
}, SyntaxKind.InvocationExpression); | ||
} | ||
|
||
private static bool IsInsideReceiveAsyncLambda(SyntaxNode node, SemanticModel semanticModel, AkkaContext akkaContext) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this might be a pretty useful thing to have for some other analysis rules in the future too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/Akka.Analyzers.Tests/Fixes/AK1000/MustNotAwaitGracefulStopInsideReceiveAsyncFixerSpecs.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #49
Changes
Converts
to
Converts
to