Improve GracefulStop() analyzer and code fix
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Jan 23, 2024
Comment on lines
+129
to
+145
| public MyActor() | ||
| { | ||
| ReceiveAsync<string>(async str => | ||
| { | ||
| await GracefulStop(TimeSpan.FromSeconds(3)); | ||
| }); | ||
|
|
||
| ReceiveAnyAsync(async _ => | ||
| { | ||
| await GracefulStop(TimeSpan.FromSeconds(3)); | ||
| }); | ||
| } | ||
|
|
||
| public Task GracefulStop(TimeSpan timeout) | ||
| { | ||
| return Task.CompletedTask; | ||
| } |
There was a problem hiding this comment.
We're not responsible for these kind of shenanigans.
Comment on lines
+64
to
+65
| return methodSymbol is { Name: "GracefulStop", IsExtensionMethod: true } | ||
| && SymbolEqualityComparer.Default.Equals(methodSymbol.ContainingType, akkaContext.AkkaCore.GracefulStopSupportType); |
There was a problem hiding this comment.
This checks that the method in question is defined within the GracefulStopSupport static class.
Arkatufus
commented
Jan 23, 2024
| return; | ||
|
|
||
| var diagnostic = Diagnostic.Create(RuleDescriptors.Ak1002DoNotAwaitOnGracefulStop, awaitExpression.GetLocation()); | ||
| ctx.ReportDiagnostic(diagnostic); | ||
| }, SyntaxKind.InvocationExpression); | ||
| } | ||
|
|
||
| private static bool IsInsideReceiveAsyncLambda(SyntaxNode node, SemanticModel semanticModel, AkkaContext akkaContext) |
There was a problem hiding this comment.
Method is moved to CodeAnalysisExtensions.cs, will be used by other analyzers.
Aaronontheweb
approved these changes
Jan 23, 2024
Comment on lines
+129
to
+145
| public MyActor() | ||
| { | ||
| ReceiveAsync<string>(async str => | ||
| { | ||
| await GracefulStop(TimeSpan.FromSeconds(3)); | ||
| }); | ||
|
|
||
| ReceiveAnyAsync(async _ => | ||
| { | ||
| await GracefulStop(TimeSpan.FromSeconds(3)); | ||
| }); | ||
| } | ||
|
|
||
| public Task GracefulStop(TimeSpan timeout) | ||
| { | ||
| return Task.CompletedTask; | ||
| } |
| return; | ||
|
|
||
| var diagnostic = Diagnostic.Create(RuleDescriptors.Ak1002DoNotAwaitOnGracefulStop, awaitExpression.GetLocation()); | ||
| ctx.ReportDiagnostic(diagnostic); | ||
| }, SyntaxKind.InvocationExpression); | ||
| } | ||
|
|
||
| private static bool IsInsideReceiveAsyncLambda(SyntaxNode node, SemanticModel semanticModel, AkkaContext akkaContext) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Make sure that the
GracefulStop()method being invoked are defined insideGracefulStopSupportstatic class and not a custom method defined by the user.