Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AK1002] Fix false positive #72

Merged
merged 3 commits into from
Feb 27, 2024
Merged

[AK1002] Fix false positive #72

merged 3 commits into from
Feb 27, 2024

Conversation

Arkatufus
Copy link
Contributor

Fixes #69

Changes

  • Make absolutely sure that Self refers to ActorBase.Self
  • Make absolutely sure that Self refers to Context.Self and all of its derivatives

Notes

There is no performant way to make sure that any arbitrary IActorRef variable refers to ActorBase.Self or Context.Self short of coding a flow analysis so this is ommitted from this fix.

Aaronontheweb
Aaronontheweb approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 2fb0601 into akkadotnet:dev Feb 27, 2024
2 checks passed
This was referenced Feb 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AK1002 false positive
2 participants
@Arkatufus @Aaronontheweb