Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User type symbol equality everywhere #82

Merged
merged 7 commits into from
Mar 7, 2024
Merged

User type symbol equality everywhere #82

merged 7 commits into from
Mar 7, 2024

Conversation

Arkatufus
Copy link
Contributor

Changes

  • Remove as many magic string as possible by referencing the actual class/methods/properties from the actual compilation instance.
  • Use type equality to make sure that each class/methods/properties actually came from the reference Akka assemblies.

Arkatufus added 6 commits March 7, 2024 01:04
@Arkatufus
Refactor AkkaContext for modelling complex contexts in the future
65d0342
@Arkatufus
Fix naming consistency
c5c4e7f
@Arkatufus
Move AkkaContext from Utility to Context
c78ea5a
@Arkatufus
Convert all codes to use strongly typed equality
9947155
@Arkatufus
Merge branch 'dev' into User-type-symbol-equality-merged
1caeefd 
# Conflicts:
#	src/Akka.Analyzers/AK1000/MustNotAwaitGracefulStopInsideReceiveAsyncAnalyzer.cs
#	src/Akka.Analyzers/AK1000/MustNotUseNewKeywordOnActorsAnalyzer.cs
#	src/Akka.Analyzers/Context/Core/Actor/AkkaCoreActorContext.cs
#	src/Akka.Analyzers/Context/Core/Actor/IAkkaCoreActorContext.cs
#	src/Akka.Analyzers/Utility/CodeAnalysisExtensions.cs
@Arkatufus
Make sure that ReceiveAsync detection is as robust as possible
976a1b2
Aaronontheweb
Aaronontheweb reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 question but otherwise looks good

src/Akka.Analyzers.Roslyn311/Akka.Analyzers.Roslyn311.csproj Outdated
@@ -12,5 +12,8 @@

<ItemGroup>
<Compile Include="..\Akka.Analyzers\**\*.cs" Exclude="..\Akka.Analyzers\obj\**\*.cs" />
<Compile Update="..\Akka.Analyzers\Context\Core\Actor\ActorContextContext.cs">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary @Arkatufus ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a strange refactor artifact by Rider, let me remove that

Aaronontheweb
Aaronontheweb approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) March 7, 2024 22:21
@Aaronontheweb Aaronontheweb merged commit 364172b into akkadotnet:dev Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb