Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion: ng-repeat on accordion-group does not refresh the view when the model changes #149

Open
fedelopez opened this issue Feb 25, 2015 · 3 comments
Assignees
Labels
Milestone

Comments

@fedelopez
Copy link

We have the following html template using the accordion component:

...
<accordion close-others="false">
<accordion-group is-open="true" ng-repeat="project in projects" heading="{{project}}">
     <project-component project-name="{{project}}" project-queues="queuesForProject(project)"...
<accordion-group is-open="true" ng-repeat="project in projects" heading="{{project}}">
...

The component managing the view above manages the projects field:

@Component(selector: 'queues-component', templateUrl: 'queuesView.html', useShadowDom: false)
class QueuesComponent implements ScopeAware, AttachAware, DetachAware {
  ...
  List<String> projects = [];
  ...

Whenever projects list changes (e.g. a new element is added to the list), the accordion-group is not redrawn. However, if we get rid of the accordion and we put the ng-repeat on a div, any change on the projects list is taken into account by the view.

Have you guys noticed any similar behaviour? any clue what are we doing wrong here?

@akserg akserg added this to the 0.6 milestone Feb 25, 2015
@akserg akserg self-assigned this Feb 25, 2015
@akserg
Copy link
Owner

akserg commented Feb 25, 2015

I have fixed other issues with Accordion component.
Can you try 0.6.5 and confirm you problem still exists?

@akserg akserg added the bug label Mar 9, 2015
@fedelopez
Copy link
Author

We have tried with 0.6.8 and the issue still persists when repeating over a list of strings.
However, we have solved our problem by repeating over a list of objects, which works fine.

@akserg
Copy link
Owner

akserg commented Mar 12, 2015

I'm glad to hear about that. So let's check what's wrong with list of
string.

On 12 March 2015 at 03:56, Fede Lopez [email protected] wrote:

We have tried with 0.6.8 and the issue still persists when repeating over
a list of strings.
However, we have solved our problem by repeating over a list of objects,
which works fine.


Reply to this email directly or view it on GitHub
#149 (comment)
.

@akserg akserg modified the milestones: 0.6, 0.7 Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants