Check Carousel unit tests

[akserg]

Check what's going wrong with Carousel unit tests environment.

[MadcapJake]

So far, I've worked out that you put css files in index.html because TranscludingComponentFactory doesn't work in this (whereas it did work in ShadowDomComponentFactory). So does this mean that you will have to include all component css files in index.html for all instances of using angular.dart.ui?

Going deeper into 3rd test now.

[MadcapJake]

3rd test succeeds after I pulled your commits, not sure what I did wrong following along with diff.

4th test is failing because you manually listed slide entries instead of using ng-repeat. I'm gonna see if I can work out why ng-repeat is failing.

[akserg]

Hi Jack,

So does this mean that you will have to include all component css files in

index.html for all instances of using angular.dart.ui?

I think all components must use original styles from bootstrap.css. As an
exclusion they could have own css files being included on html page. We
must avoid workaround to download css files of component ourself. Better
use browser to download them, else this way can be fragile and buggy.

Any thoughts, objections?

Regards,
Sergey.

On 28 May 2014 03:57, Jake Russo [email protected] wrote:

3rd test succeeds after I pulled your commits, not sure what I did wrong
following along with diff.

4th test is failing because you manually listed slide entries instead of
using ng-repeat. I'm gonna see if I can work out why ng-repeat is failing.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/85#issuecomment-44357098
.