Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking some commands that could be made by the guests. #5

Open
snowc0de opened this issue Aug 31, 2020 · 2 comments
Open

Blocking some commands that could be made by the guests. #5

snowc0de opened this issue Aug 31, 2020 · 2 comments

Comments

@snowc0de
Copy link

Could it be possible to block some commands, like exit for example. If a guest wants to quit the room and type exit to go out of its terminal, the session of everybody ends, and that's maybe not really cool.

Another idea would be to create blacklists of commands. For example the host could say "I don't want the guests to run xyz commands, without my agreement"

Tell me what you think.

@akshaykmr
Copy link
Owner

Could it be possible to block some commands, like exit for example. If a guest wants to quit the room and type exit to go out of its terminal, the session of everybody ends, and that's maybe not really cool.

I'm not sure I understand the scenario. Can you be more explicit:

  • Who are the participants? (say one streamer A, one guest viewer B)
  • What is the sequence of events ?
  • Is collaboration mode enabled ?

Another idea would be to create blacklists of commands. For example the host could say "I don't want the guests to run xyz commands, without my agreement

I don't see the reason why we should filter commands when streamer has given explicit permission for collaboration. It's all about trust, a similar scenario would be two colleagues in an office troubleshooting something together on one's machine. You don't expect him/her to sudo rm -rf sitting right alongside you, right? To sum it up, only enable collaboration mode for trusted people, and end the stream when you're done.

@snowc0de
Copy link
Author

snowc0de commented Sep 1, 2020

This is an example:
I create a new terminal and host it on Oorja. Then a guest comes to help me troubleshooting something. But this host forget that it's not his terminal and press CTRL+D, and ends the session by mistake.
Now that I think about, you right there is no reason to have a blacklist of commands but maybe just a warning like "Warning, you typed 'exit' do you really wants to quit the communication?".

Of course this is a very minor idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants