15 run inference on baskerville #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the custom pipeline method
…inputs from being used during inference
…cter length of the first language passed to the dataset loader.
…der, now save multiple runs under subdirectories named via the seed
…nt_result--seed combination directory to exist already, since this is caught in the jobscript creation I don't forsee this being an issue
3 tasks
lannelin
reviewed
Dec 6, 2024
lannelin
requested changes
Dec 6, 2024
| @@ -8,6 +11,10 @@ def aggregate_score(probs: torch.Tensor) -> torch.Tensor: | |||
| return 1 - torch.mean(distance) | |||
|
|
|||
|
|
|||
| def zero_one_loss_ceil(y_target, y_pred): | |||
There was a problem hiding this comment.
I think this is no longer really the zero_one_loss if we're doing a ceil, it's just a ==, so we can remove? or keep it as it was for use over a set of results (rather than single row)
tests/test_inference.py
Outdated
|
|
||
| dummy_correct_output = [0, 1, 0, 1, 0] | ||
|
|
||
| assert hamming_loss(dummy_target, dummy_correct_output) == pytest.approx( |
There was a problem hiding this comment.
we don't need to test sklearn's function so can remove this
There was a problem hiding this comment.
Also removed this test
…o translation to allow additional confidence measures
lannelin
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: