Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Story]: Edit and Remove Notes in Assurance Case Editor #467

Closed
8 tasks done
kallewesterling opened this issue Jun 5, 2024 · 5 comments
Closed
8 tasks done

Comments

@kallewesterling
Copy link
Collaborator

Role

As an assurance case editor

Desired Feature

I want the ability to edit and remove notes that I have created within the "notes" functionality of the assurance case editor

Benefit

so that I can correct errors or update the information as the case develops or my understanding changes

Acceptance Criteria

GIVEN I have previously added a note to an assurance case,
AND I am currently viewing or editing the assurance case's notes,
WHEN I select a note that I have contributed to the conversation,
THEN I should have options to either edit or remove the note,
AND if I choose to edit, I should be able to modify the content in-place and save changes,
AND if I choose to remove, the note should be deleted immediately after confirmation.

Dependencies

No response

Technical Notes

  • Implement UI components for editing and removing notes directly within the assurance case editor.
  • Ensure that changes to notes are synchronised with the backend database.
  • Consider implementing a confirmation dialog for removing notes to prevent accidental deletions.
  • Ensure that edit and remove functionalities are accessible to all users.

Definition of Done

  • The feature fulfills all acceptance criteria.
  • The code is reviewed and meets team coding standards.
  • All unit, integration, and end-to-end tests are passed.
  • The feature meets accessibility standards set for the project.
  • The code passes the CI/CD pipeline quality controls (style and linting).
  • The feature is merged into the main branch.
  • The feature is deployed and functional in the QA environment.
  • The feature was demonstrated to the team and accepted by the product owner.
@RichGriff
Copy link
Collaborator

@cptanalatriste to check Comment endpoint if we can PUT and DELETE

@RichGriff
Copy link
Collaborator

I have now implemented the following

  • API now has a new endpoint for fetching a single comment as well as update and delete
  • Reworked the /comments/{assurance_case_id}/ endpoint to make this work with the above
  • Ability for a user to toggle whether they would like to edit the comment or not
  • Ability for a user to remove the comment

Please note: This assumes that any user with access to the case can therefore edit/delete the note.

@cptanalatriste Can you please review the PR #507

@chrisdburr
Copy link
Collaborator

This was in Ready but seems like it should be In Review. Please can you verify @cptanalatriste?

@cptanalatriste
Copy link
Collaborator

Last thingI knew about this issue was a PR by @RichGriff and I requested some minor comments. However, I've seen it was already merged.

@RichGriff , shall we move this to "Review"?

@chrisdburr
Copy link
Collaborator

Discussed with @RichGriff. Confirmed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants