-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create progress_report.md #69
base: main
Are you sure you want to change the base?
Conversation
Hi team, I have put together a first version of a report for the year. Idea is to use it both in the monthly (async ideally but a bit late) and upcoming strategy session. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loadsa bitty comments - I think this is a fantastic initiative and I'm delighted that you've started to structure the project report like this @Davsarper ! Well done! Very very helpful to tell the story clearly 💖
@@ -0,0 +1,296 @@ | |||
# Data Safe Haven project report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add in the dates that this report covers? I got a bit confused in my first read through 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes definitly, it wa a confusing one because I wanted it to be for the monthly but in practice has everything since the last strategy session. Will add and then update.
Do we feel it is best to have one report that updates or monthly reports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In TPS we do a single file for each 6 month report that we add to each month and I think it works really well. Otherwise it can really feel like you're repeating a lot of information each month. So doing the monthly updates 1) lets you focus on a pull request on what has changed rather than having to have two files open to compare, and 2) lets the project manager (@Davsarper!) build up the report so there's not much extra work to do by the time submitting the report comes around!
- Pen testing done: little found | ||
- Penetration tested arranged and will be done in September | ||
- Preparation for release v4.1.0: Deployment of different SRE variants, Security checklist | ||
- Reviewing v4.1.0: No significant problems is deployment logs, Problems found in security checklist relating to MSRDS | ||
- Working on [Release 4.1.0](https://github.com/alan-turing-institute/data-safe-haven/issues/1544): fixes bugs and introduces necessary updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the order should be put into chronological order rather than reverse? I got pretty confused until I went and read the issue itself!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - adding comments as I go through - I'm also a bit confused about the fact that this release has already happened (🎉!) So which parts of this issue are still open?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of the confusion here I think is that I finished this too late for the team to come in and give a more comprenhensive overview of progress and where we are at.
The story issue is open because it refers to ongoing work to keep making releases, and we are working on 4.2
That warrants the questions on wheter to have ongoing Stories or more time bound ones, and also we need to better explain what goes into which story as work towards 4.2 is happening in Codebase Maintenance. This story deals with the release itself.
And yes, happy to reverse order/clarify timeline.
|
||
##### Strategy | ||
|
||
Through several team wide sessions we jointly produced a [project strategy](https://thealanturininstitute.sharepoint.com/:p:/s/SafeHaven/Ebrp4Iyc9M1NpPTgpgHdj5kB7HPvH-2gM0oNd97jJu6oxw?e=eN0ZFw)https://thealanturininstitute.sharepoint.com/:p:/s/SafeHaven/Ebrp4Iyc9M1NpPTgpgHdj5kB7HPvH-2gM0oNd97jJu6oxw?e=eN0ZFw a long, medium and short term levels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great and I'm super proud of it - I think it needs to be integrated into the GitHub repository to make it more accessible..... could that be a project management task for the next quarter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending commit until I capture that action as a to do
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
- DBeaver drivers were not installing correctly during VM building, so it tries to download them from the internet. | ||
No problem on T1, but fails on T2. | ||
- Factoring storage creation and account deployments out of main deployment script now allows for a more resilient process (not having to re-run everything when one fails) | ||
- MS changed the name of Azure Directory to Microsoft Entra ID which made necessary to spend time updating documentation and code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol
Co-authored-by: Kirstie Whitaker <[email protected]>
#### Progress | ||
[SATRE specification](https://satre-specification.readthedocs.io/en/stable/) published, and available for contribution and reproducibility in its [open repository](https://github.com/sa-tre/satre-specification). | ||
|
||
Currently Turing and HIC have self-evaluated against it and evaluations are available openly, several conversations ongoing about other institutions doing the same and making them available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we'd like to list orgs we know are going through this:
- KCL
- Sheffield
- North West NHS SNSDE
- NHS SDE technology group reviewing SATRE
Co-authored-by: Kirstie Whitaker <[email protected]>
|
||
Direct and explicit work on this story have not been carried out (not scheduled in this period). | ||
|
||
We are now establishing the engagement pipleline by creating an internal CRM (sharepoint based currently). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CRM is currently structured to be very like informal and just for us to track internally what's going on with different convos.
If this becomes a significant story, do we want to put effort into formalising this a bit more?
@JimMadge a little bit of an extension of the Slack thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the feeling this isn't big enough to be a story. At least not with the level of investment we currently give it.
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a bunch of comments.
There is also some Markdown formatting that would be worth doing to make sure this document is compatible with popular processors. Empty lines after headings, empty lines before and after lists.
Would also suggest s/GH/GitHub/g
.
Reports/progress_report.md
Outdated
|
||
Included stories are those that were scheduled and/or prioritised over this period (February 2023-February 2024), some not scheduled stories are included when there are updates for them regardless (indirect contributions from other stories, relevant work recently started, or something to report in general). | ||
|
||
## Infrastructure as code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think all of this section is "Infrastructure as Code".
Is that the pillar name? I think I might have made this argument before. It is probably more fair to call it "codebase development" or something like that.
##### Definition of done | ||
On the release of a new major version which removes legacy, script-based deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want that, we need it to exist for all stories first!
💯
I think I've come to realise it is a problem to have these stories which have no clear end point. Development isn't a story, that's just my job 😄.
##### Definition of done | ||
On the release of a new major version which removes legacy, script-based deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to get towards this with "sprints" for IaC and Maintenance stories.
Arrived at a IAC MVP version of the code, available as a penetration tested [pre-release](https://github.com/alan-turing-institute/data-safe-haven/releases/tag/v5.0.0-rc.1). | ||
|
||
This new code is better and easier for users to deploy, however some incompatibilities with the old code would require extensive work. | ||
As PowerShell heads to its final release it was decided not to work on fixing these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KirstieJane 🙏
These are main references and milestones, a more complete list is available on the [story issue](https://github.com/alan-turing-institute/data-safe-haven-team/issues/28) | ||
- Codebase pre-release https://github.com/alan-turing-institute/data-safe-haven/releases/tag/v5.0.0-rc.1 | ||
- Next version milestone https://github.com/alan-turing-institute/data-safe-haven/milestone/20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to sort out the milestones to reflect the new thinking w.r.t sprints aligned with DSGs.
|
||
We had a detailed[ handover meeting](https://hackmd.io/kh6siuZcTdCxcfYryAvypw) to go over each process, the idea is that moving forward TRESA directly owns processes and their improvement. | ||
|
||
We have also identified areas of work for TRESA to fully establish itself as a service area, these need to be elaborated into a full proposal with sprints and stories but main areas are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel I need to catch up with @helendduncan and @jemrobinson about this.
I sketched out some "sprints" for TRESA to try and start moving from being purely reactionary to making progress. I want to avoid stepping on @helendduncan's toes though and don't want to be dictating what TRESA's focus is if that isn't my role here.
|
||
We had a detailed[ handover meeting](https://hackmd.io/kh6siuZcTdCxcfYryAvypw) to go over each process, the idea is that moving forward TRESA directly owns processes and their improvement. | ||
|
||
We have also identified areas of work for TRESA to fully establish itself as a service area, these need to be elaborated into a full proposal with sprints and stories but main areas are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KirstieJane would you like/be able to be involved in planning for TRESA like you have for DSH?
## Meta | ||
Work and stories that do not belong directly in any pillars but are necessary for all | ||
|
||
### Project strategy and ways of working [#43](https://github.com/alan-turing-institute/data-safe-haven-team/issues/43) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this is also a story that has no end.
Does everything we do need to be a story?
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Jim Madge <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Jim Madge <[email protected]>
Co-authored-by: Jim Madge <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Jim Madge <[email protected]>
Co-authored-by: Jim Madge <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
Co-authored-by: Kirstie Whitaker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have commited all suggestions and made a note of all feedback regarding format and pending conversations about work/stories/strategies into a new issue here.
The idea then is to close this PR and to apply changes in a new report for the new period (which then we keep updating).
I think it makes sense to start a new one from this february as the present report already encompasses a whole year and goes from strategy session to strategy session
Reports/progress_report.md
Outdated
#### Goal | ||
Provide a space for those involved in building, using and responsible for governance of TREs to discuss and recommend best practices. | ||
- [ ] Host online working spaces, events and workshops to support the UK TRE Community | ||
- [ ] Share best practices i.e. for making radiology data available for researchers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [ ] Share best practices i.e. for making radiology data available for researchers | |
- [ ] Share best practices e.g. for making radiology data available for researchers |
committing my own suggestions, unsure it is best practice but they should not be controversial (they are direct applications of feedback) Co-authored-by: Kirstie Whitaker <[email protected]>
initial commit of progress report for monthly and strategy session