Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and optimize the solver code #24

Open
aldro61 opened this issue Mar 31, 2017 · 3 comments
Open

Review and optimize the solver code #24

aldro61 opened this issue Mar 31, 2017 · 3 comments
Assignees
@gletarte

Comments

@aldro61
Copy link
Owner

aldro61 commented Mar 31, 2017

Make sure you benchmark for speed and memory before merging into master.
@gletarte gletarte self-assigned this Mar 31, 2017
@aldro61 aldro61 modified the milestones: v1.0.0, v1.0.0 Apr 4, 2017
aldro61 added a commit that referenced this issue Apr 6, 2017
@aldro61
Merge pull request #38 from aldro61/mem_leak
18801aa 
Fixed solver memory leaks. (Issue #24)
@aldro61
Copy link
Owner Author

aldro61 commented Apr 6, 2017

Some memory leaks were fixed in PR #38.

@aldro61
Copy link
Owner Author

aldro61 commented Apr 11, 2017

Can someone write a small piece of code that leads to a memory leak, so that we can all reproduce the problem and check if our modifications solve it?

@aldro61
Copy link
Owner Author

aldro61 commented Apr 11, 2017

Please read this: https://docs.scipy.org/doc/numpy/user/c-info.how-to-extend.html#reference-counting. Very important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gletarte gletarte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aldro61 @gletarte