Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible improvements to how we test Memorious #199

Open
sunu opened this issue Nov 29, 2021 · 0 comments
Open

Possible improvements to how we test Memorious #199

sunu opened this issue Nov 29, 2021 · 0 comments

Comments

@sunu
Copy link
Contributor

sunu commented Nov 29, 2021

Currently the bulk of the testing we do in Memorious is based on mocking the interface of various functions to perform the tests. Often this doesn't test the expected output; instead we check whether the mocked function was called with the expected input or not. This is not super useful in preventing breakage.

Instead of using mocks, we could run a set of small crawlers against a fixed set of web pages built to test various Memorious operations. And we should check whether the output produced by the test crawlers matches the expected output or not. These end-to-end tests should make our testing suite more robust and we shouldn't need to use mocks to test functionality where unit testing is hard to do.

@Rosencrantz Rosencrantz added this to Aleph Nov 2, 2022
@Rosencrantz Rosencrantz moved this to 🏷️ Triage in Aleph Nov 2, 2022
@Rosencrantz Rosencrantz moved this from 🏷️ Triage to Feature Backlog in Aleph Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 🚀Feature Backlog
Development

No branches or pull requests

1 participant