From e73875729a9937a59eecc8bcb1765095b43db2e4 Mon Sep 17 00:00:00 2001
From: libaoxu <admin@example.com>
Date: Wed, 16 Oct 2019 09:49:05 +0800
Subject: [PATCH 1/2] =?UTF-8?q?1.=20=E5=8F=AA=E8=A6=81=E9=87=8D=E5=86=99eq?=
 =?UTF-8?q?uals=EF=BC=8C=E5=B0=B1=E5=BF=85=E9=A1=BB=E9=87=8D=E5=86=99hashC?=
 =?UTF-8?q?ode=202.=20=E7=9B=B8=E5=90=8C=E5=8F=82=E6=95=B0=E7=B1=BB?=
 =?UTF-8?q?=E5=9E=8B=EF=BC=8C=E7=9B=B8=E5=90=8C=E4=B8=9A=E5=8A=A1=E5=90=AB?=
 =?UTF-8?q?=E4=B9=89=EF=BC=8C=E6=89=8D=E5=8F=AF=E4=BB=A5=E4=BD=BF=E7=94=A8?=
 =?UTF-8?q?Java=E7=9A=84=E5=8F=AF=E5=8F=98=E5=8F=82=E6=95=B0=EF=BC=8C?=
 =?UTF-8?q?=E9=81=BF=E5=85=8D=E4=BD=BF=E7=94=A8Object?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../java/rule/oop/VarargsParameterRule.java   | 44 ++++++++++++++++
 .../java/rule/set/EqualsHashCodeRule.java     | 51 +++++++++++++++++++
 p3c-pmd/src/main/resources/messages.xml       |  6 +++
 p3c-pmd/src/main/resources/messages_en.xml    |  6 +++
 .../main/resources/rulesets/java/ali-oop.xml  | 12 +++++
 .../main/resources/rulesets/java/ali-set.xml  | 18 +++++++
 6 files changed, 137 insertions(+)
 create mode 100644 p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/oop/VarargsParameterRule.java
 create mode 100644 p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/set/EqualsHashCodeRule.java

diff --git a/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/oop/VarargsParameterRule.java b/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/oop/VarargsParameterRule.java
new file mode 100644
index 000000000..a44832732
--- /dev/null
+++ b/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/oop/VarargsParameterRule.java
@@ -0,0 +1,44 @@
+package com.alibaba.p3c.pmd.lang.java.rule.oop;
+
+/*
+ * Copyright 1999-2017 Alibaba Group.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import com.alibaba.p3c.pmd.I18nResources;
+import com.alibaba.p3c.pmd.lang.AbstractXpathRule;
+import com.alibaba.p3c.pmd.lang.java.util.ViolationUtils;
+import net.sourceforge.pmd.lang.ast.Node;
+
+/**
+ * [Mandatory]
+ *
+ * @author leonard99559
+ * @date 2019/10/16
+ */
+public class VarargsParameterRule extends AbstractXpathRule {
+    private static final String XPATH = "//FormalParameter[@Varargs = 'true' and ./Type[@TypeImage = 'Object']]";
+
+    public VarargsParameterRule() {
+        setXPath(XPATH);
+    }
+
+    @Override
+    public void addViolation(Object data, Node node, String arg) {
+        ViolationUtils.addViolationWithPrecisePosition(this, node, data,
+                I18nResources.getMessage("java.oop.VarargsParameterRule.rule.msg",
+                        node.getImage()));
+    }
+
+}
\ No newline at end of file
diff --git a/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/set/EqualsHashCodeRule.java b/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/set/EqualsHashCodeRule.java
new file mode 100644
index 000000000..810e5caab
--- /dev/null
+++ b/p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/set/EqualsHashCodeRule.java
@@ -0,0 +1,51 @@
+package com.alibaba.p3c.pmd.lang.java.rule.set;
+
+/*
+ * Copyright 1999-2017 Alibaba Group.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import com.alibaba.p3c.pmd.lang.java.rule.AbstractAliRule;
+import net.sourceforge.pmd.lang.ast.Node;
+import net.sourceforge.pmd.lang.java.ast.ASTCompilationUnit;
+import org.jaxen.JaxenException;
+
+import java.util.List;
+
+/**
+ * [Mendatory] Equals method must be with hashCode() method.
+ *
+ * @author leonard99559
+ * @date 2019/10/16
+ */
+public class EqualsHashCodeRule extends AbstractAliRule {
+
+    @Override
+    public Object visit(ASTCompilationUnit rootNode, Object data) {
+
+        try {
+            List<Node> nodeList = rootNode.findChildNodesWithXPath(
+                    "//ClassOrInterfaceBodyDeclaration[./Annotation[@AnnotationName = 'Override']]" +
+                            "//MethodDeclaration[@MethodName = 'hashCode' or @MethodName = 'equals']");
+            if (nodeList.size() == 1) {
+                addViolationWithMessage(data, nodeList.get(0),
+                        "java.set.EqualsHashCodeRule.rule.msg");
+            }
+        } catch (JaxenException e) {
+            e.printStackTrace();
+        }
+        return super.visit(rootNode, data);
+    }
+
+}
diff --git a/p3c-pmd/src/main/resources/messages.xml b/p3c-pmd/src/main/resources/messages.xml
index b5b1cba95..417e0f5c5 100644
--- a/p3c-pmd/src/main/resources/messages.xml
+++ b/p3c-pmd/src/main/resources/messages.xml
@@ -260,6 +260,9 @@
     <entry key="java.set.UnsupportedExceptionWithModifyAsListRule.rule.msg">
         <![CDATA[ 使用工具类Arrays.asList()把数组转换成集合时，不能使用其修改集合相关的方法，它的add/remove/clear方法会抛出UnsupportedOperationException异常。 ]]>
     </entry>
+    <entry key="java.set.EqualsHashCodeRule.rule.msg">
+        <![CDATA[只要覆写equals，就必须覆写hashCode。]]>
+    </entry>
     <!-- constant -->
     <entry key="java.constant.UndefineMagicConstantRule.violation.msg">
         <![CDATA[ 魔法值【%s】]]>
@@ -348,6 +351,9 @@
         <![CDATA[说明：BigDecimal(double)存在精度损失风险，在精确计算或值比较的场景中可能会导致业务逻辑异常。]]>
     </entry>
 
+    <entry key="java.oop.VarargsParameterRule.rule.msg">
+        <![CDATA[相同参数类型，相同业务含义，才可以使用 Java 的可变参数，避免使用 Object。]]>
+    </entry>
     <!-- comment -->
     <entry key="java.comment.CommentsMustBeJavadocFormatRule.rule.msg">
         <![CDATA[类、类属性、类方法的注释必须使用javadoc规范，使用/**内容*/格式，不得使用//xxx方式和/*xxx*/方式。]]>
diff --git a/p3c-pmd/src/main/resources/messages_en.xml b/p3c-pmd/src/main/resources/messages_en.xml
index 4666a7f33..08bd7cbfe 100644
--- a/p3c-pmd/src/main/resources/messages_en.xml
+++ b/p3c-pmd/src/main/resources/messages_en.xml
@@ -262,6 +262,9 @@ Note: Below are the problems created by usage of Executors for thread pool creat
     <entry key="java.set.UnsupportedExceptionWithModifyAsListRule.rule.msg">
         <![CDATA[Do not use methods which will modify the list after using Arrays.asList to convert array to list, otherwise methods like add/remove/clear will throw UnsupportedOperationException. ]]>
     </entry>
+    <entry key="java.set.EqualsHashCodeRule.rule.msg">
+        <![CDATA[Equals method must be with hashCode() method.]]>
+    </entry>
     <!-- constant -->
     <entry key="java.constant.UndefineMagicConstantRule.violation.msg">
         <![CDATA[Magic value [%s] ]]>
@@ -348,6 +351,9 @@ Note: Below are the problems created by usage of Executors for thread pool creat
     <entry key="java.oop.BigDecimalAvoidDoubleConstructorRule.rule.msg.desc">
         <![CDATA[Note：Use the constructor BigDecimal(String) or valueOf method of BigDecimal. Inside valueOf the toString of Double is executed, which truncate the mantissa according to the precision of double.]]>
     </entry>
+    <entry key="java.oop.VarargsParameterRule.rule.msg">
+        <![CDATA[Use detail Class for Varargs, do not use Object。]]>
+    </entry>
 
     <!-- comment -->
     <entry key="java.comment.CommentsMustBeJavadocFormatRule.rule.msg">
diff --git a/p3c-pmd/src/main/resources/rulesets/java/ali-oop.xml b/p3c-pmd/src/main/resources/rulesets/java/ali-oop.xml
index 77ce92875..ca6837b9d 100644
--- a/p3c-pmd/src/main/resources/rulesets/java/ali-oop.xml
+++ b/p3c-pmd/src/main/resources/rulesets/java/ali-oop.xml
@@ -153,5 +153,17 @@ Positive example:
 ]]>
         </example>
     </rule>
+    <rule name="VarargsParameterRule" language="java"
+          message="java.oop.VarargsParameterRule.rule.msg"
+          class="com.alibaba.p3c.pmd.lang.java.rule.oop.VarargsParameterRule">
+        <priority>1</priority>
+        <example>
+            <![CDATA[
+Negative example:
+   private void method(Param a, Param b, Object... objs) {
 
+   }
+         ]]>
+        </example>
+    </rule>
 </ruleset>
diff --git a/p3c-pmd/src/main/resources/rulesets/java/ali-set.xml b/p3c-pmd/src/main/resources/rulesets/java/ali-set.xml
index 1df62235e..121b63b7f 100644
--- a/p3c-pmd/src/main/resources/rulesets/java/ali-set.xml
+++ b/p3c-pmd/src/main/resources/rulesets/java/ali-set.xml
@@ -129,5 +129,23 @@ Negative example:
          ]]>
       </example>
     </rule>
+    <rule name="EqualsHashCodeRule" language="java"
+          message="java.set.EqualsHashCodeRule.rule.msg"
+          class="com.alibaba.p3c.pmd.lang.java.rule.set.EqualsHashCodeRule">
+        <priority>1</priority>
+        <example>
+            <![CDATA[
+Positive example:
+    @Override
+    public int hashCode() {
+        return ...;
+    }
 
+    @Override
+    public boolean equals(Object obj) {
+        return ...;
+    }
+         ]]>
+        </example>
+    </rule>
 </ruleset>

From 3feca7f3f5a1bbbb430f18856b94476e944e2308 Mon Sep 17 00:00:00 2001
From: 11102769 <11102769@vivo.xyz>
Date: Mon, 20 Jan 2020 13:33:17 +0800
Subject: [PATCH 2/2] =?UTF-8?q?1.=20=E5=8A=A0=E5=85=A5unit=20testcase=202.?=
 =?UTF-8?q?=20=E5=AE=8C=E5=96=84=E6=8F=90=E7=A4=BAtips?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 p3c-pmd/src/main/resources/messages.xml       | 10 ++-
 p3c-pmd/src/main/resources/messages_en.xml    | 10 ++-
 .../main/resources/rulesets/java/ali-oop.xml  |  6 +-
 .../main/resources/rulesets/java/ali-set.xml  | 33 ++++++--
 .../pmd/lang/java/rule/oop/OopRuleTest.java   |  1 +
 .../pmd/lang/java/rule/set/SetRulesTest.java  |  1 +
 .../rule/oop/xml/VarargsParameterRule.xml     | 27 +++++++
 .../java/rule/set/xml/EqualsHashCodeRule.xml  | 80 +++++++++++++++++++
 8 files changed, 157 insertions(+), 11 deletions(-)
 create mode 100644 p3c-pmd/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/oop/xml/VarargsParameterRule.xml
 create mode 100644 p3c-pmd/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/set/xml/EqualsHashCodeRule.xml

diff --git a/p3c-pmd/src/main/resources/messages.xml b/p3c-pmd/src/main/resources/messages.xml
index 417e0f5c5..a3d7e0ed4 100644
--- a/p3c-pmd/src/main/resources/messages.xml
+++ b/p3c-pmd/src/main/resources/messages.xml
@@ -261,7 +261,13 @@
         <![CDATA[ 使用工具类Arrays.asList()把数组转换成集合时，不能使用其修改集合相关的方法，它的add/remove/clear方法会抛出UnsupportedOperationException异常。 ]]>
     </entry>
     <entry key="java.set.EqualsHashCodeRule.rule.msg">
-        <![CDATA[只要覆写equals，就必须覆写hashCode。]]>
+        <![CDATA[
+            关于hashCode和equals的处理，遵循如下规则：
+                1） 只要覆写equals，就必须覆写hashCode。
+                2） 因为Set存储的是不重复的对象，依据hashCode和equals进行判断，所以Set存储的对象必须覆写这两个方法。
+                3） 如果自定义对象作为Map的键，那么必须覆写hashCode和equals。
+            说明：String已覆写hashCode和equals方法，所以我们可以愉快地使用String对象作为key来使用。
+        ]]>
     </entry>
     <!-- constant -->
     <entry key="java.constant.UndefineMagicConstantRule.violation.msg">
@@ -352,7 +358,7 @@
     </entry>
 
     <entry key="java.oop.VarargsParameterRule.rule.msg">
-        <![CDATA[相同参数类型，相同业务含义，才可以使用 Java 的可变参数，避免使用 Object。]]>
+        <![CDATA[相同参数类型，相同业务含义，才可以使用Java的可变参数，避免使用Object。说明：可变参数必须放置在参数列表的最后。（提倡同学们尽量不用可变参数编程）]]>
     </entry>
     <!-- comment -->
     <entry key="java.comment.CommentsMustBeJavadocFormatRule.rule.msg">
diff --git a/p3c-pmd/src/main/resources/messages_en.xml b/p3c-pmd/src/main/resources/messages_en.xml
index 08bd7cbfe..4b4cbc55d 100644
--- a/p3c-pmd/src/main/resources/messages_en.xml
+++ b/p3c-pmd/src/main/resources/messages_en.xml
@@ -263,7 +263,13 @@ Note: Below are the problems created by usage of Executors for thread pool creat
         <![CDATA[Do not use methods which will modify the list after using Arrays.asList to convert array to list, otherwise methods like add/remove/clear will throw UnsupportedOperationException. ]]>
     </entry>
     <entry key="java.set.EqualsHashCodeRule.rule.msg">
-        <![CDATA[Equals method must be with hashCode() method.]]>
+        <![CDATA[
+            Regarding the processing of hashCode and equals, follow the rules below:
+                1) As long as you override 'equals', you must override 'hashCode'.
+                2) 'Set' stores unique objects, its uniqueness is judged by 'equals' and 'hashCode'. So the objects stored by 'Set' must override these two methods.
+                3) If the custom object is used as the map key, then 'hashCode' and 'equals' must be overridden.
+            Note: String has overridden the 'hashCode' and 'equals' methods, so we can happily use String objects as keys.
+        ]]>
     </entry>
     <!-- constant -->
     <entry key="java.constant.UndefineMagicConstantRule.violation.msg">
@@ -352,7 +358,7 @@ Note: Below are the problems created by usage of Executors for thread pool creat
         <![CDATA[Note：Use the constructor BigDecimal(String) or valueOf method of BigDecimal. Inside valueOf the toString of Double is executed, which truncate the mantissa according to the precision of double.]]>
     </entry>
     <entry key="java.oop.VarargsParameterRule.rule.msg">
-        <![CDATA[Use detail Class for Varargs, do not use Object。]]>
+        <![CDATA[Only with the same parameter type and same business logic, you can use varargs and avoid using Object. Note: Varargs must be placed at the end of the parameter list. (Better to avoid programming with varargs)]]>
     </entry>
 
     <!-- comment -->
diff --git a/p3c-pmd/src/main/resources/rulesets/java/ali-oop.xml b/p3c-pmd/src/main/resources/rulesets/java/ali-oop.xml
index ca6837b9d..22eb84945 100644
--- a/p3c-pmd/src/main/resources/rulesets/java/ali-oop.xml
+++ b/p3c-pmd/src/main/resources/rulesets/java/ali-oop.xml
@@ -159,8 +159,12 @@ Positive example:
         <priority>1</priority>
         <example>
             <![CDATA[
+Positive example:
+   private void method(int a, int b, int... varargs) {
+
+   }
 Negative example:
-   private void method(Param a, Param b, Object... objs) {
+   private void method(int a, int b, Object... varargs) {
 
    }
          ]]>
diff --git a/p3c-pmd/src/main/resources/rulesets/java/ali-set.xml b/p3c-pmd/src/main/resources/rulesets/java/ali-set.xml
index 121b63b7f..6e1cd3196 100644
--- a/p3c-pmd/src/main/resources/rulesets/java/ali-set.xml
+++ b/p3c-pmd/src/main/resources/rulesets/java/ali-set.xml
@@ -136,14 +136,35 @@ Negative example:
         <example>
             <![CDATA[
 Positive example:
-    @Override
-    public int hashCode() {
-        return ...;
+    public class Foo {
+
+        @Override
+        public boolean equals(Object o) {
+            // ...
+        }
+
+        @Override
+        public int hashCode() {
+            // ...
+        }
+    }
+
+Negative example 1:
+    public class Foo {
+
+        @Override
+        public boolean equals(Object o) {
+            // ...
+        }
     }
 
-    @Override
-    public boolean equals(Object obj) {
-        return ...;
+Negative example 2:
+    public class Foo {
+
+        @Override
+        public int hashCode() {
+            // ...
+        }
     }
          ]]>
         </example>
diff --git a/p3c-pmd/src/test/java/com/alibaba/p3c/pmd/lang/java/rule/oop/OopRuleTest.java b/p3c-pmd/src/test/java/com/alibaba/p3c/pmd/lang/java/rule/oop/OopRuleTest.java
index 9ab81aa27..47be8e49c 100644
--- a/p3c-pmd/src/test/java/com/alibaba/p3c/pmd/lang/java/rule/oop/OopRuleTest.java
+++ b/p3c-pmd/src/test/java/com/alibaba/p3c/pmd/lang/java/rule/oop/OopRuleTest.java
@@ -38,5 +38,6 @@ public void setUp() {
         addRule(RULESET, "PojoMustOverrideToStringRule");
         addRule(RULESET, "StringConcatRule");
         addRule(RULESET, "BigDecimalAvoidDoubleConstructorRule");
+        addRule(RULESET, "VarargsParameterRule");
     }
 }
diff --git a/p3c-pmd/src/test/java/com/alibaba/p3c/pmd/lang/java/rule/set/SetRulesTest.java b/p3c-pmd/src/test/java/com/alibaba/p3c/pmd/lang/java/rule/set/SetRulesTest.java
index b96c6e3e9..b3b736e14 100644
--- a/p3c-pmd/src/test/java/com/alibaba/p3c/pmd/lang/java/rule/set/SetRulesTest.java
+++ b/p3c-pmd/src/test/java/com/alibaba/p3c/pmd/lang/java/rule/set/SetRulesTest.java
@@ -35,5 +35,6 @@ public void setUp() {
         addRule(RULESET, "ConcurrentExceptionWithModifyOriginSubListRule");
         addRule(RULESET, "DontModifyInForeachCircleRule");
         addRule(RULESET, "UnsupportedExceptionWithModifyAsListRule");
+        addRule(RULESET, "EqualsHashCodeRule");
     }
 }
diff --git a/p3c-pmd/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/oop/xml/VarargsParameterRule.xml b/p3c-pmd/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/oop/xml/VarargsParameterRule.xml
new file mode 100644
index 000000000..0db9bf1e7
--- /dev/null
+++ b/p3c-pmd/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/oop/xml/VarargsParameterRule.xml
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<test-data xmlns="http://pmd.sourceforge.net/rule-tests"
+           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+           xsi:schemaLocation="http://pmd.sourceforge.net/rule-tests https://pmd.sourceforge.io/rule-tests_1_0_0.xsd">
+
+    <code-fragment id="varargs-with-object-type">
+        <![CDATA[
+    public class Foo {
+        public void bar(int a, int b, Object... varargs) { // BAD
+            return;
+        }
+        public void bar(int a, int b, int... varargs) {
+            return;
+        }
+    }
+        ]]>
+    </code-fragment>
+    <test-code>
+        <description>varargs-with-object-type</description>
+        <expected-problems>1</expected-problems>
+        <expected-linenumbers>2</expected-linenumbers>
+        <code-ref id="varargs-with-object-type"/>
+    </test-code>
+
+
+    <!-- ====================================================================== -->
+</test-data>
\ No newline at end of file
diff --git a/p3c-pmd/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/set/xml/EqualsHashCodeRule.xml b/p3c-pmd/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/set/xml/EqualsHashCodeRule.xml
new file mode 100644
index 000000000..ffabef18c
--- /dev/null
+++ b/p3c-pmd/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/set/xml/EqualsHashCodeRule.xml
@@ -0,0 +1,80 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<test-data xmlns="http://pmd.sourceforge.net/rule-tests"
+           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+           xsi:schemaLocation="http://pmd.sourceforge.net/rule-tests https://pmd.sourceforge.io/rule-tests_1_0_0.xsd">
+
+    <code-fragment id="sets-EqualsHashCodeRule-ok"><![CDATA[
+        public class Foo { // line 1
+            private Long id;
+
+            @Override
+            public boolean equals(Object o) { // line 5
+                if (this == o) {
+                    return true;
+                }
+                if (o == null || getClass() != o.getClass()) {
+                    return false;
+                }
+                Foo foo = (Foo) o;
+                return Objects.equals(id, foo.id);
+            }
+
+            @Override
+            public int hashCode() { // line 17
+                return Objects.hash(id);
+            }
+        }
+    ]]>
+    </code-fragment>
+
+    <test-code>
+        <description>sets-EqualsHashCodeRule-ok.</description>
+        <expected-problems>0</expected-problems>
+        <code-ref id="sets-EqualsHashCodeRule-ok"/>
+    </test-code>
+
+    <code-fragment id="sets-EqualsHashCodeRule-missHashCodeWarn"><![CDATA[
+        public class Foo { // line 1
+            private Long id;
+
+            @Override
+            public boolean equals(Object o) { // line 5
+                if (this == o) {
+                    return true;
+                }
+                if (o == null || getClass() != o.getClass()) {
+                    return false;
+                }
+                Foo foo = (Foo) o;
+                return Objects.equals(id, foo.id);
+            }
+        }
+    ]]>
+    </code-fragment>
+
+    <test-code>
+        <description>sets-EqualsHashCodeRule-missHashCodeWarn.</description>
+        <expected-problems>1</expected-problems>
+        <expected-linenumbers>5</expected-linenumbers>
+        <code-ref id="sets-EqualsHashCodeRule-missHashCodeWarn"/>
+    </test-code>
+
+    <code-fragment id="sets-EqualsHashCodeRule-missEqualsWarn"><![CDATA[
+        public class Foo { // line 1
+            private Long id;
+
+            @Override
+            public int hashCode() { // line 5
+                return Objects.hash(id);
+            }
+        }
+    ]]>
+    </code-fragment>
+
+    <test-code>
+        <description>sets-EqualsHashCodeRule-missEqualsWarn.</description>
+        <expected-problems>1</expected-problems>
+        <expected-linenumbers>5</expected-linenumbers>
+        <code-ref id="sets-EqualsHashCodeRule-missEqualsWarn"/>
+    </test-code>
+</test-data>