-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Change "flip preview" to "flip webcam" #323
Comments
This is a suggestion for the GUI app, right? |
Yes.. I could make a PR for it, but I wanted to check if you think it would be a good idea first |
We've not published the sources of the GUI app yet. But we'll take this suggestion into account! |
Ahh, I thought you meant cam_fomm.py when you said GUI app, I didn't know there was another.. For me (Linux user :)) everything that isn't a pure terminal app counts as GUI, even if it's just a video stream without buttons |
Haha, strictly talking cam_fomm.py also has GUI :) |
virtual camera is missing |
I think maybe it wasn't clear exactly what I meant so I created PR #333 for it. You can reject it if you prefer the current behaviour |
I think it would be more useful if flip was applied immediately after reading a frame from the webcam, rather than only flipping the preview_frame.
The reason is that I don't have my webcam straight ahead of me, so my face is looking to the left (when watching the unflipped preview). This makes it very awkward to get a good match with an avatar that is facing right, and just flipping the preview doesn't change anything except how I see it, I still have to turn my head away from the screen to align with the avatar. But if the input frame is flipped instead, it will make the alignment easier in this case.
Alternatively another hotkey could be added to flip the avatar image, which would also solve this problem.
The text was updated successfully, but these errors were encountered: