Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

burly-open-bookmark completion shows no entries after startup #21

Closed
minad opened this issue Nov 23, 2020 · 3 comments
Closed

burly-open-bookmark completion shows no entries after startup #21

minad opened this issue Nov 23, 2020 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@minad
Copy link

minad commented Nov 23, 2020

Hi,

I like the idea of reusing builtin functionality for the purpose of storing window/frame configuration! I've one small issue though - After starting Emacs, M-x burly-open-bookmark shows no entries, since the bookmark file is somehow not yet loaded. After M-x bookmark-jump the file is loaded and then burly is populated too, when doing M-x burly-open-bookmark again.

Independently of the issue, I wonder if it is necessary to do the URL encoding? It seems to me that bookmarks can be simple alists? Generally I would prefer to use the native elisp format instead of the less readable url encoding. Or maybe there is a technical reason to use the url format? Is it the idea that urls are better for external sharing? Does burly also hook into some internal emacs url mechanism for opening urls? Your readme states that you also provide commands working with the URL strings, with the added qualification that most users probably won't use these.

@alphapapa
Copy link
Owner

alphapapa commented Nov 23, 2020

Thanks, that will be a simple bug to fix. I assumed that bookmark-alist was loaded automatically, but apparently not.

URLs are an implementation detail at the moment. For more discussion, please see #7

@alphapapa alphapapa self-assigned this Nov 23, 2020
@alphapapa alphapapa added the bug Something isn't working label Nov 23, 2020
@alphapapa alphapapa modified the milestones: 0.1, 0.1.1 Nov 23, 2020
@minad
Copy link
Author

minad commented Nov 23, 2020

@alphapapa Thank you for the answer, I will read through #7 and maybe comment there!

@ssl19
Copy link

ssl19 commented Nov 29, 2021

According to bookmark-view.el, I've found out a workaround :
(advice-add 'burly-bookmark-names :before (lambda () (bookmark-maybe-load-default-file)))

I'm not very familiar with Emacs and Elisp, so I don't know if this has any side effects

@alphapapa alphapapa modified the milestones: 0.1.1, 0.3 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants