Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a consistent return_type for Count* primitives #156

Open
thehomebrewnerd opened this issue Jun 16, 2022 · 0 comments
Open

Use a consistent return_type for Count* primitives #156

thehomebrewnerd opened this issue Jun 16, 2022 · 0 comments

Comments

@thehomebrewnerd
Copy link
Contributor

In some counting primitives we are using a Double return type (like PartOfSpeechCount) while in others IntegerNullable is used as the return type (like NumUniqueSeparators).

Given that all of the counting primitives should be returning a whole number (or optionally null), IntegerNullable seems like a more appropriate return type to use than Double. We should investigate if there is a reason for using Double in some primitives, and, if possible, convert these to use an IntegerNullable return type.

Primitives to study:

  • MedianWordLength
  • PartOfSpeechCount
  • PunctuationCount
  • TitleWordCount
  • TotalWordLength
  • UpperCaseCount
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant