Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system adb if present #6

Closed
DaRacci opened this issue Aug 9, 2024 · 5 comments
Closed

Use system adb if present #6

DaRacci opened this issue Aug 9, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@DaRacci
Copy link

DaRacci commented Aug 9, 2024

I use NixOS which requires patched binaries due to how it works so the downloaded adb tools at runtime won't work, before attempting to download the tools during runtime why not do a quick check to see if the command is present within the systems path?

@Meister1593
Copy link
Collaborator

Hello. I've made some changes on separate branch, can you check if it works for you?
https://github.com/alvr-org/ADBForwarder/actions/runs/10396080132 you can find linux artifact here
https://github.com/alvr-org/ADBForwarder/actions/runs/10396080132/artifacts/1813782991 - direct link

@Meister1593 Meister1593 self-assigned this Aug 14, 2024
@Meister1593 Meister1593 added the enhancement New feature or request label Aug 14, 2024
@DaRacci
Copy link
Author

DaRacci commented Aug 15, 2024

I'll give this a shot tonight thanks

@DaRacci
Copy link
Author

DaRacci commented Aug 15, 2024

Yeah its working great now.

@Meister1593
Copy link
Collaborator

Okay, thanks, i will merge it into main and include into next release

@Meister1593
Copy link
Collaborator

Closed via #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants