Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the spinner test to use fake timers #3

Open
ameerkat opened this issue Jan 5, 2019 · 0 comments
Open

Migrate the spinner test to use fake timers #3

ameerkat opened this issue Jan 5, 2019 · 0 comments
Labels
enhancement New feature or request minor

Comments

@ameerkat
Copy link
Owner

ameerkat commented Jan 5, 2019

E.g. in lolex, spent some time trying this to no avail. Ended up using a sleep function. The main issue is that there is a risk that the check for the spinner will happen too late and the rendering will have happened therefore the spinner check will fail.
@ameerkat ameerkat changed the title Migrate the spinner test to use fake timers. Migrate the spinner test to use fake timers Jan 5, 2019
@ameerkat ameerkat added enhancement New feature or request and removed task labels Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ameerkat