Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MetricsService#createEvent(string, long) / or replace int version #57

Open
detsam opened this issue Apr 8, 2016 · 0 comments
Open
Milestone

Comments

@detsam
Copy link
Member

detsam commented Apr 8, 2016

In practice, there is most of timing / quantities values that are has type of long. So, at the moment there is permanent cast from long to int type.

I want suggest to add long version of "MetricsService#createEvent" method, or replace int version.

There is no any downgrade of performance is expected, cos JVM JIT is smart enough to keep int where possible, even over smart type casts.

So that we would support wide range of values just for free.

@detsam detsam added this to the 0.3.0 milestone Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant