Skip to content

Turn off QCTools Report generation if recording time is set to greater than 200 minutes #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iamdamosuzuki opened this issue Apr 11, 2025 · 1 comment
Assignees
Labels
FADGI Wishlist Items that are not within the scope of current FADGI work, but could be in scope of future funding

Comments

@iamdamosuzuki
Copy link
Contributor

From what I can tell, QCTools reports wont work for files over 200 minutes long until changes are made to how QCTools stores data. However, this means that it's possible for vrecord to spend time and processing power making bad QCTools reports. see: #880

I think it would be very helpful to automatically turn off the generation of QCTools files if the user-set recording time is set to greater than 200 minutes. this would just be a simple failsafe to keep vrecord from trying to make a bad file without making the user change the QCTools generation settings.

I'll try making a pull request for this shortly.

@iamdamosuzuki iamdamosuzuki self-assigned this Apr 11, 2025
@iamdamosuzuki iamdamosuzuki added the FADGI Wishlist Items that are not within the scope of current FADGI work, but could be in scope of future funding label Apr 11, 2025
@iamdamosuzuki
Copy link
Contributor Author

This is taken care of by PR #888

We'll have to turn this off when issues with QCTools are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FADGI Wishlist Items that are not within the scope of current FADGI work, but could be in scope of future funding
Projects
None yet
Development

No branches or pull requests

1 participant