Skip to content

Commit 71f6c80

Browse files
Issues/0168 valgrind issue ctlrender with unsupported input format (#179)
* setup CI to run valgrind without libtiff * use different exit code to differentiate valgrind memory error exit code (3) from program termination caused by exit(1)
1 parent 1e37465 commit 71f6c80

File tree

3 files changed

+183
-134
lines changed

3 files changed

+183
-134
lines changed

.github/workflows/docker_linuxes.yml

+11
Original file line numberDiff line numberDiff line change
@@ -213,3 +213,14 @@ jobs:
213213

214214
- name: Run unit tests (ctest) within the Docker image
215215
run: docker run ctl:latest sh -c "cd ./build && ctest"
216+
217+
ubuntu-22-04-no-libtiff-valgrind:
218+
runs-on: ubuntu-latest
219+
steps:
220+
- uses: actions/checkout@v4
221+
- name: Build the Docker image
222+
run: docker build --no-cache --rm -f ./docker/Dockerfile_ubuntu_22.04_no_libtiff_valgrind -t ctl:latest .
223+
224+
- name: Run the docker that runs valgrind
225+
run: docker run ctl:latest
226+
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
FROM ubuntu:22.04
2+
3+
RUN apt-get update
4+
5+
# disable interactive install
6+
ENV DEBIAN_FRONTEND noninteractive
7+
8+
# install developement tools
9+
RUN apt-get -y install cmake
10+
RUN apt-get -y install g++
11+
12+
# install developement debugging tools
13+
RUN apt-get -y install valgrind
14+
15+
# install CTL dependencies
16+
RUN apt-get -y install libopenexr-dev
17+
#RUN apt-get -y install libtiff-dev
18+
19+
# build CTL
20+
WORKDIR /usr/src/CTL
21+
COPY . .
22+
WORKDIR /usr/src/CTL/build
23+
RUN rm -R * || true
24+
RUN cmake .. -DCMAKE_BUILD_TYPE=Debug
25+
RUN make
26+
RUN make install
27+
28+
# finalize docker environment
29+
WORKDIR /usr/src/CTL/build
30+
31+
# run valgrind
32+
CMD bash /usr/src/CTL/resources/test/scripts/run_valgrind.sh
33+

0 commit comments

Comments
 (0)