Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for release channel(s) and crossorigin=anonymous scripts and links #4403

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Add support for release channel(s) and crossorigin=anonymous scripts and links #4403

wants to merge 3 commits into from

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Mar 18, 2020 •
edited
Loading

Summary

Fixes #4600.

Follow-up on #4390.

Todo

  • Add a amp_release_channel filter.
  • Make sure that lts or other scripts are recognized in paired browsing.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v1.6 milestone Mar 18, 2020
@googlebot googlebot added the cla: yes Signed the Google CLA label Mar 18, 2020
@westonruter westonruter mentioned this pull request Mar 18, 2020
Merged
5 tasks
@westonruter westonruter changed the base branch from update/amphtml-2003031842100 to develop March 18, 2020 18:06
@westonruter westonruter force-pushed the add/release-channel-and-crossorigin-anonymous branch from 154d2b7 to 851f183 Compare March 18, 2020 18:06
@westonruter westonruter mentioned this pull request Apr 15, 2020
Closed
@westonruter westonruter modified the milestones: v1.6, v1.7 Jun 16, 2020
@schlessera schlessera added the WS:Core Work stream for Plugin core label Aug 18, 2020
@westonruter westonruter mentioned this pull request Nov 6, 2020
Closed
@westonruter westonruter removed this from the v2.1 milestone Feb 12, 2021
@schlessera schlessera mentioned this pull request Apr 2, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Signed the Google CLA WS:Core Work stream for Plugin core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate support for AMP release channels
3 participants
@westonruter @schlessera @googlebot