Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make applying patches easier and better Readme #72

Open
wants to merge 7 commits into
base: nougat
Choose a base branch
from
Open

Make applying patches easier and better Readme #72

wants to merge 7 commits into from

Conversation

joe2k01
Copy link

@joe2k01 joe2k01 commented Apr 11, 2017

No description provided.

@gw0
Copy link

gw0 commented Apr 13, 2017

Can you update the Readme to be cleaner and use features of Markdown? Such as:

  • usually there is a new line after each title
  • single-line commands should be written between ` and `, they render like command
  • multi-line commands should be written between ``` and ```
  • add command to git clone this repo
  • my preference would also be to remove the numbered list and just use paragraphs or just a multi-line block of commands

@ikalkov
Copy link
Member

ikalkov commented Apr 13, 2017

I agree with @gw0.
Additionally, I have to admit I don't like the idea of fixed patches being stored in the device tree. How about creating a dedicated repository and adding it to the manifest?

@joe2k01
Copy link
Author

joe2k01 commented Apr 13, 2017

I stored patches in the device tree because the patches in the wiki are outdated and because this is the way I manage patches in other android device trees, surely a dedicated repo could be a better option.
BTW, @gw0 what do you mean by 'add command to git clone this repo', just the git clone and then device repo link?

@ikalkov
Copy link
Member

ikalkov commented Apr 13, 2017

True, the patching tutorial in the wiki may be outdated, but I don't see yet how keeping required changes as files ist going to improve the situation.

@joe2k01
Copy link
Author

joe2k01 commented Apr 13, 2017

I think this is a better way to manage patches because of the using of an automated script for applying them, but as you said a dedicated repo it's better than keeping patches in the device tree

@gw0
Copy link

gw0 commented Apr 13, 2017

@joe2k01 I am building Android for the first time. With "add command to git clone this repo" I mean there is no instruction into where you should clone this repository, something like (unfortunately this fails):

$ git clone https://github.com/android-rpi/device_brcm_rpi3 ./device/brcm/rpi3
fatal: destination path './device/brcm/rpi3' already exists and is not an empty directory.

@joe2k01
Copy link
Author

joe2k01 commented Apr 13, 2017

Actually, there is the instruction. It's described in the first link

@gw0
Copy link

gw0 commented Apr 13, 2017

Oh, you mean this in local_manifests in default.xml:

<project path="device/brcm/rpi3" name="device_brcm_rpi3" revision="nougat" remote="arpi"/>

@joe2k01
Copy link
Author

joe2k01 commented Apr 13, 2017

@ikalkov are you considering the merge?
@gw0 yes

@ikalkov
Copy link
Member

ikalkov commented Apr 14, 2017

@joe2k01, yes, if you remove those patch files. I'm out of office now, but I'll take a closer look at this merge next week.

@joe2k01
Copy link
Author

joe2k01 commented Apr 17, 2017

Removed patches, should I pull request them in the hardware repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants