Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journal.ByWorkspacePath can't handle whitespace in file paths #7

Open
andydandy74 opened this issue Sep 19, 2015 · 7 comments
Open
Assignees

Comments

@andydandy74
Copy link
Owner

@ikeough - found the first bug by pure luck.
I rearranged the folder structure of the test files and renamed some of the subfolders.
Some of the folder names now contained whitespaces.
The path in the resulting journal file will look like this:

C:\temp\DynamoAutomation\slave/graphs\Revit2016\CountWalls.dyn

So it turned slave graphs into slave/graphs.
Revit will not be able to find a Revit model with such a path nor will the Dynamo addin find a graph with such a path.

@andydandy74
Copy link
Owner Author

Also - I wonder if this may happen with other special characters as well?

andydandy74 pushed a commit that referenced this issue Sep 19, 2015
@ikeough ikeough closed this as completed Sep 20, 2015
@ikeough ikeough reopened this Sep 20, 2015
andydandy74 pushed a commit that referenced this issue Oct 6, 2015
@ikeough
Copy link
Collaborator

ikeough commented Oct 6, 2015

@andydandy74 We should re-open this. It's replacing spaces with / because I made it do that when debugging why it didn't work for some paths. We should set it back, I just haven't had time.

@ikeough ikeough reopened this Oct 6, 2015
andydandy74 pushed a commit that referenced this issue Oct 7, 2015
This reverts commit 1241fb4.
@andydandy74
Copy link
Owner Author

Okay @ikeough - I reverted it. Can you remember a specific case where leaving the original whitespace didn't work?

@andydandy74
Copy link
Owner Author

Seems that this is just a standard limitation of Revit journal playback.

@andydandy74
Copy link
Owner Author

Let's have a look at this again...
https://twitter.com/PragmaticPrxs/status/963420422741069824

@andydandy74 andydandy74 reopened this Feb 13, 2018
@andydandy74 andydandy74 self-assigned this Nov 30, 2018
@steinah6
Copy link

What's the current status of this? I'd love to use your tools but renaming all of our office directories is not an option right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants