From 41396942c12a709ebc1d911d7f9af092e02fac42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carl=20F=C3=BCrstenberg?= Date: Thu, 21 Apr 2016 17:04:47 +0200 Subject: [PATCH] fix(gulp): build images before rev-replace When running `gulp build` the rev manifest will be remade, but the task "build:client" which uses this file doesn't depend on "build:images" which populates this file. The result is that when running `build`, rev-replace will be unable to replace images as it doesn't wait for images to be filled in. Solution is to simply have "build:client" depend upon "build:images" --- app/templates/gulpfile.babel(gulp).js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/templates/gulpfile.babel(gulp).js b/app/templates/gulpfile.babel(gulp).js index c75c1f0d3..085b6734f 100644 --- a/app/templates/gulpfile.babel(gulp).js +++ b/app/templates/gulpfile.babel(gulp).js @@ -561,7 +561,7 @@ gulp.task('build', cb => { gulp.task('clean:dist', () => del([`${paths.dist}/!(.git*|.openshift|Procfile)**`], {dot: true})); -gulp.task('build:client', ['transpile:client', 'styles', 'html', 'constant'], () => { +gulp.task('build:client', ['transpile:client', 'styles', 'html', 'constant', 'build:images'], () => { var manifest = gulp.src(`${paths.dist}/${clientPath}/assets/rev-manifest.json`); var appFilter = plugins.filter('**/app.js', {restore: true});