Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding of looks-same options #26

Open
laurentgoudet opened this issue Jul 15, 2019 · 0 comments · May be fixed by #27
Open

Allow overriding of looks-same options #26

laurentgoudet opened this issue Jul 15, 2019 · 0 comments · May be fixed by #27

Comments

@laurentgoudet
Copy link

The looks-same options sometimes need to be tweaked, e.g. to bump the tolerance of the antialiasingTolerance levels, is order for a specific test of test suite to pass (e.g. difference of font rendering between OSs can sometimes be tricky)

Having compareScreenshot take an optional LooksSameOptions 4th param would allow more flexibility, without having to fork the lib.
@laurentgoudet laurentgoudet linked a pull request Jul 15, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow overriding of looks-same options
1 participant
@laurentgoudet