[selection] - event rowSelectionChanged - pass GridCol along with GridRow

[DmitryEfimenko]

currently event rowSelectionChanged has the following signature:

on.rowSelectionChanged($scope, function (row, event) { ... })

I have a use case when I'd also find useful information about column being clicked.

Detailed scenario:
Clicking on the row has an event associated (ex: redirects to another state). However, the very last column of each row is a custom column that allows deleting of that row. Currently clicking on the delete button in the given row will also trigger rowSelectionChanged event, which is not desired just for that column.
Given that I had information about GridCol in this event, I could write something like:

on.rowSelectionChanged($scope, function(row, col, event) {
    if (col.name != 'delete') {
        $state.go('superState');
    }
});

This would be a breaking change since it would change the signature of the event. If I'm given a green light, I'll submit a PR.

[wesleycho]

Wouldn't a better solution that doesn't require a BC change be to hang the column reference onto the event object?

[DmitryEfimenko]

sure it'd be better to avoid BC, but event does not seem to the right place for the col.

[wesleycho]

If the function signature is to be changed, the event should be first in the arguments list in order to allow for additional arguments. Otherwise, it's not worth the additional pain to make the suggested BC change when any future request may make it more problematic.

[DmitryEfimenko]

I agree with that.