Remove SupportsSIUnitSystem => true property overrides (#1537)

Fixes #1463

---------

Co-authored-by: Andreas Gullberg Larsen <[email protected]>

Author: lipchev

UnitsNet.Tests/CustomCode/AbsorbedDoseOfIonizingRadiationTests.cs

@@ -24,7 +24,6 @@ namespace UnitsNet.Tests.CustomCode
     public class AbsorbedDoseOfIonizingRadiationTests : AbsorbedDoseOfIonizingRadiationTestsBase
     {
         // Override properties in base class here
-        protected override bool SupportsSIUnitSystem => true;
         protected override double CentigraysInOneGray => 100;
         protected override double FemtograysInOneGray => 1E+15;
         protected override double GigagraysInOneGray => 1E-9;

UnitsNet.Tests/CustomCode/AccelerationTests.cs

@@ -7,8 +7,6 @@ namespace UnitsNet.Tests
 {
     public class AccelerationTests : AccelerationTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double KilometersPerSecondSquaredInOneMeterPerSecondSquared => 1E-3;
 
         protected override double MetersPerSecondSquaredInOneMeterPerSecondSquared => 1;

UnitsNet.Tests/CustomCode/AmountOfSubstanceTests.cs

@@ -28,8 +28,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AmountOfSubstanceTests : AmountOfSubstanceTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double CentimolesInOneMole => 1e2;
         protected override double CentipoundMolesInOneMole => 0.002204622621848776 * 1e2;
         protected override double DecimolesInOneMole => 1e1;
@@ -71,9 +69,10 @@ public void NumberOfParticlesInTwoMolesIsDoubleAvogadroConstant()
         }
 
         [Theory]
+        // 10 Moles of Oxygen weight 10 times as much as 1 Mole of Oxygen (MolarMass)
         [InlineData(10, AmountOfSubstanceUnit.Mole,
-            KnownQuantities.MolarMassOfOxygen, MolarMassUnit.GramPerMole,
-            10 * KnownQuantities.MolarMassOfOxygen, MassUnit.Gram)] // 10 Moles of Oxygen weight 10 times as much as 1 Mole of Oxygen (MolarMass)
+                    KnownQuantities.MolarMassOfOxygen, MolarMassUnit.GramPerMole,
+                    10 * KnownQuantities.MolarMassOfOxygen, MassUnit.Gram)]
         public void MassFromAmountOfSubstanceAndMolarMass(
             double amountOfSubstanceValue, AmountOfSubstanceUnit amountOfSubstanceUnit,
             double molarMassValue, MolarMassUnit molarMassUnit,
@@ -88,10 +87,11 @@ public void MassFromAmountOfSubstanceAndMolarMass(
         }
 
         [Theory]
+        // molarity(HCl) = 5g / (1.2L * 36.46) = 0.114 mol/l = 0.114 M
         [InlineData(5, MassUnit.Gram,
-            KnownQuantities.MolarMassHClInGramsPerMole, MolarMassUnit.GramPerMole,
-            1.2, VolumeUnit.Liter,
-            0.1142805, MolarityUnit.MolePerLiter)] // molarity(HCl) = 5g / (1.2L * 36.46) = 0.114 mol/l = 0.114 M
+                    KnownQuantities.MolarMassHClInGramsPerMole, MolarMassUnit.GramPerMole,
+                    1.2, VolumeUnit.Liter,
+                    0.1142805, MolarityUnit.MolePerLiter)]
         public void MolarityFromComponentMassAndSolutionVolume(
             double componentMassValue, MassUnit componentMassUnit,
             double componentMolarMassValue, MolarMassUnit componentMolarMassUnit,
@@ -109,10 +109,11 @@ public void MolarityFromComponentMassAndSolutionVolume(
         }
 
         [Theory]
+        // 1.2 L of solution required for obtaining 0.1142805 Moles/L from 5g HCl
         [InlineData(5, MassUnit.Gram,
-            KnownQuantities.MolarMassHClInGramsPerMole, MolarMassUnit.GramPerMole,
-            0.1142805, MolarityUnit.MolePerLiter,
-            1.2, VolumeUnit.Liter)] // 1.2 L of solution required for obtaining 0.1142805 Moles/L from 5g HCl
+                    KnownQuantities.MolarMassHClInGramsPerMole, MolarMassUnit.GramPerMole,
+                    0.1142805, MolarityUnit.MolePerLiter,
+                    1.2, VolumeUnit.Liter)]
         public void VolumeSolutionFromComponentMassAndDesiredConcentration(
             double componentMassValue, MassUnit componentMassUnit,
             double componentMolarMassValue, MolarMassUnit componentMolarMassUnit,

UnitsNet.Tests/CustomCode/AmplitudeRatioTests.cs

@@ -8,7 +8,6 @@ namespace UnitsNet.Tests
 {
     public class AmplitudeRatioTests : AmplitudeRatioTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double DecibelMicrovoltsInOneDecibelVolt => 121;
 
         protected override double DecibelMillivoltsInOneDecibelVolt => 61;
@@ -51,7 +50,7 @@ public void ExpectVoltageConvertedToAmplitudeRatioCorrectly(double voltage, doub
             // Amplitude ratio increases linearly by 20 dBV with power-of-10 increases of voltage.
             ElectricPotential v = ElectricPotential.FromVolts(voltage);
 
-            double actual = AmplitudeRatio.FromElectricPotential(v).DecibelVolts;
+            var actual = AmplitudeRatio.FromElectricPotential(v).DecibelVolts;
             Assert.Equal(expected, actual);
         }
 
@@ -65,8 +64,8 @@ public void ExpectAmplitudeRatioConvertedToVoltageCorrectly(double amplitudeRati
         {
             // Voltage increases by powers of 10 for every 20 dBV increase in amplitude ratio.
             AmplitudeRatio ar = AmplitudeRatio.FromDecibelVolts(amplitudeRatio);
-
-            double actual = ar.ToElectricPotential().Volts;
+            
+            var actual = ar.ToElectricPotential().Volts;
             Assert.Equal(expected, actual);
         }
 
@@ -80,8 +79,8 @@ public void ExpectAmplitudeRatioConvertedToVoltageCorrectly(double amplitudeRati
         public void AmplitudeRatioToPowerRatio_50OhmImpedance(double dBmV, double expected)
         {
             AmplitudeRatio ampRatio = AmplitudeRatio.FromDecibelMillivolts(dBmV);
-
-            double actual = Math.Round(ampRatio.ToPowerRatio(ElectricResistance.FromOhms(50)).DecibelMilliwatts, 2);
+            
+            var actual = Math.Round(ampRatio.ToPowerRatio(ElectricResistance.FromOhms(50)).DecibelMilliwatts, 2);
             Assert.Equal(expected, actual);
         }
 
@@ -93,8 +92,8 @@ public void AmplitudeRatioToPowerRatio_50OhmImpedance(double dBmV, double expect
         public void AmplitudeRatioToPowerRatio_75OhmImpedance(double dBmV, double expected)
         {
             AmplitudeRatio ampRatio = AmplitudeRatio.FromDecibelMillivolts(dBmV);
-
-            double actual = Math.Round(ampRatio.ToPowerRatio(ElectricResistance.FromOhms(75)).DecibelMilliwatts, 2);
+            
+            var actual = Math.Round(ampRatio.ToPowerRatio(ElectricResistance.FromOhms(75)).DecibelMilliwatts, 2);
             Assert.Equal(expected, actual);
         }
     }

UnitsNet.Tests/CustomCode/AngleTests.cs

@@ -8,7 +8,6 @@ namespace UnitsNet.Tests
 {
     public class AngleTests : AngleTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double RadiansInOneRadian => 1;
         protected override double DeciradiansInOneRadian => 1E1;
         protected override double CentiradiansInOneRadian => 1E2;

UnitsNet.Tests/CustomCode/AreaDensityTests.cs

@@ -28,8 +28,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AreaDensityTests : AreaDensityTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double GramsPerSquareMeterInOneKilogramPerSquareMeter => 1000;
 
         protected override double KilogramsPerSquareMeterInOneKilogramPerSquareMeter => 1;

UnitsNet.Tests/CustomCode/AreaMomentOfInertiaTests.cs

@@ -28,8 +28,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class AreaMomentOfInertiaTests : AreaMomentOfInertiaTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double CentimetersToTheFourthInOneMeterToTheFourth => 1e8;
 
         protected override double DecimetersToTheFourthInOneMeterToTheFourth => 1e4;

UnitsNet.Tests/CustomCode/AreaTests.cs

@@ -8,8 +8,6 @@ namespace UnitsNet.Tests
 {
     public class AreaTests : AreaTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double SquareKilometersInOneSquareMeter => 1E-6;
 
         protected override double SquareMetersInOneSquareMeter => 1;
@@ -71,7 +69,7 @@ public void AreaTimesDensityEqualsLinearDensity()
         [InlineData(0.5, 0.19634954084936208)]
         [InlineData(1, 0.7853981633974483)]
         [InlineData(2, 3.141592653589793)]
-        public void AreaFromCicleDiameterCalculatedCorrectly(double diameterMeters, double expected)
+        public void AreaFromCircleDiameterCalculatedCorrectly(double diameterMeters, double expected)
         {
             Length diameter = Length.FromMeters(diameterMeters);
 
@@ -85,7 +83,7 @@ public void AreaFromCicleDiameterCalculatedCorrectly(double diameterMeters, doub
         [InlineData(0.5, 0.7853981633974483)]
         [InlineData(1, 3.141592653589793)]
         [InlineData(2, 12.566370614359173)]
-        public void AreaFromCicleRadiusCalculatedCorrectly(double radiusMeters, double expected)
+        public void AreaFromCircleRadiusCalculatedCorrectly(double radiusMeters, double expected)
         {
             Length radius = Length.FromMeters(radiusMeters);
 

UnitsNet.Tests/CustomCode/BitRateTests.cs

@@ -27,8 +27,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class BitRateTests : BitRateTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
-
         protected override double BitsPerSecondInOneBitPerSecond => 1;
         protected override double BytesPerSecondInOneBitPerSecond => 1.25E-1;
 

UnitsNet.Tests/CustomCode/BrakeSpecificFuelConsumptionTests.cs

@@ -8,8 +8,6 @@ namespace UnitsNet.Tests
 {
     public class BrakeSpecificFuelConsumptionTests : BrakeSpecificFuelConsumptionTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
-
         protected override double GramsPerKiloWattHourInOneKilogramPerJoule => 3600000000;
 
         protected override double KilogramsPerJouleInOneKilogramPerJoule => 1.0;
@@ -26,15 +24,15 @@ public void PowerTimesBrakeSpecificFuelConsumptionEqualsMassFlow()
         [Fact]
         public void DoubleDividedByBrakeSpecificFuelConsumptionEqualsSpecificEnergy()
         {
-            SpecificEnergy massFlow = 2.0 / BrakeSpecificFuelConsumption.FromKilogramsPerJoule(4.0);
+            SpecificEnergy massFlow = 2 / BrakeSpecificFuelConsumption.FromKilogramsPerJoule(4);
             Assert.Equal(SpecificEnergy.FromJoulesPerKilogram(0.5), massFlow);
         }
 
         [Fact]
         public void BrakeSpecificFuelConsumptionTimesSpecificEnergyEqualsEnergy()
         {
-            double value = BrakeSpecificFuelConsumption.FromKilogramsPerJoule(20.0) * SpecificEnergy.FromJoulesPerKilogram(10.0);
-            Assert.Equal(200.0, value);
+            var value = BrakeSpecificFuelConsumption.FromKilogramsPerJoule(20) * SpecificEnergy.FromJoulesPerKilogram(10);
+            Assert.Equal(200, value);
         }
     }
 }

UnitsNet.Tests/CustomCode/CoefficientOfThermalExpansionTests.cs

@@ -27,8 +27,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class CoefficientOfThermalExpansionTests : CoefficientOfThermalExpansionTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double PerDegreeCelsiusInOnePerKelvin => 1.0;
 
         protected override double PerDegreeFahrenheitInOnePerKelvin => 0.5555555555555556;

UnitsNet.Tests/CustomCode/CompressibilityTests.cs

@@ -32,7 +32,5 @@ public class CompressibilityTests : CompressibilityTestsBase
         protected override double InverseBarsInOneInversePascal => 1e-5;
         protected override double InversePoundsForcePerSquareInchInOneInversePascal => 1.450377377302092151542e-4;
         protected override double InverseAtmospheresInOneInversePascal => 9.86923266716013e-6;
-
-        protected override bool SupportsSIUnitSystem => true;
     }
 }

UnitsNet.Tests/CustomCode/DensityTests.cs

@@ -7,8 +7,6 @@ namespace UnitsNet.Tests
 {
     public class DensityTests : DensityTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
-
         protected override double MilligramsPerCubicMeterInOneKilogramPerCubicMeter => 1e6;
 
         protected override double GramsPerCubicCentimeterInOneKilogramPerCubicMeter => 1e-3;

UnitsNet.Tests/CustomCode/DoseAreaProductTests.cs

@@ -23,7 +23,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class DoseAreaProductTests : DoseAreaProductTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
         protected override double CentigraySquareCentimetersInOneGraySquareMeter => 1E+6;
         protected override double CentigraySquareDecimetersInOneGraySquareMeter => 1E+4;
         protected override double CentigraySquareMetersInOneGraySquareMeter => 100;

UnitsNet.Tests/CustomCode/DurationTests.cs

@@ -9,8 +9,6 @@ namespace UnitsNet.Tests
 {
     public class DurationTests : DurationTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double DaysInOneSecond => 1.15741e-5;
 
         protected override double HoursInOneSecond => 0.0002777784;

UnitsNet.Tests/CustomCode/DynamicViscosityTests.cs

@@ -8,8 +8,6 @@ namespace UnitsNet.Tests
 {
     public class DynamicViscosityTests : DynamicViscosityTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
-
         protected override double CentipoiseInOneNewtonSecondPerMeterSquared => 1e3;
         protected override double MicropascalSecondsInOneNewtonSecondPerMeterSquared => 1e6;
         protected override double MillipascalSecondsInOneNewtonSecondPerMeterSquared => 1e3;

UnitsNet.Tests/CustomCode/ElectricAdmittanceTests.cs

@@ -27,7 +27,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricAdmittanceTests : ElectricAdmittanceTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double NanosiemensInOneSiemens => 1E9;
         protected override double NanomhosInOneSiemens => 1E9;
 

UnitsNet.Tests/CustomCode/ElectricApparentPowerTests.cs

@@ -23,8 +23,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricApparentPowerTests : ElectricApparentPowerTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
-
         protected override double VoltamperesInOneVoltampere => 1;
 
         protected override double KilovoltamperesInOneVoltampere => 1E-3;

UnitsNet.Tests/CustomCode/ElectricCapacitanceTests.cs

@@ -23,8 +23,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricCapacitanceTests : ElectricCapacitanceTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double FaradsInOneFarad => 1;
 
         protected override double MillifaradsInOneFarad => 1e3;

UnitsNet.Tests/CustomCode/ElectricChargeDensityTests.cs

@@ -27,7 +27,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricChargeDensityTests : ElectricChargeDensityTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
         protected override double CoulombsPerCubicMeterInOneCoulombPerCubicMeter => 1;
     }
 }

UnitsNet.Tests/CustomCode/ElectricChargeTests.cs

@@ -7,7 +7,6 @@ namespace UnitsNet.Tests
 {
     public class ElectricChargeTests : ElectricChargeTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double CoulombsInOneCoulomb => 1;
         protected override double MilliampereHoursInOneCoulomb => 2.77777777777e-1;
         protected override double AmpereHoursInOneCoulomb => 2.77777777777e-4;

UnitsNet.Tests/CustomCode/ElectricConductanceTests.cs

@@ -27,7 +27,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricConductanceTests : ElectricConductanceTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double NanosiemensInOneSiemens => 1E9;
         protected override double NanomhosInOneSiemens => 1E9;
 

UnitsNet.Tests/CustomCode/ElectricConductivityTests.cs

@@ -29,7 +29,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricConductivityTests : ElectricConductivityTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
         protected override double SiemensPerMeterInOneSiemensPerMeter => 1;
         protected override double SiemensPerInchInOneSiemensPerMeter => 2.54e-2;
         protected override double SiemensPerFootInOneSiemensPerMeter => 3.048e-1;

UnitsNet.Tests/CustomCode/ElectricCurrentDensityTests.cs

@@ -27,7 +27,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricCurrentDensityTests : ElectricCurrentDensityTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
         protected override double AmperesPerSquareMeterInOneAmperePerSquareMeter => 1;
         protected override double AmperesPerSquareInchInOneAmperePerSquareMeter => 6.4516e-4;
         protected override double AmperesPerSquareFootInOneAmperePerSquareMeter => 9.290304e-2;

UnitsNet.Tests/CustomCode/ElectricCurrentGradientTests.cs

@@ -29,7 +29,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricCurrentGradientTests : ElectricCurrentGradientTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
         protected override double AmperesPerSecondInOneAmperePerSecond => 1;
         protected override double AmperesPerMillisecondInOneAmperePerSecond => 1e-03;
         protected override double AmperesPerMicrosecondInOneAmperePerSecond => 1e-06;

UnitsNet.Tests/CustomCode/ElectricCurrentTests.cs

@@ -9,8 +9,6 @@ namespace UnitsNet.Tests
 {
     public class ElectricCurrentTests : ElectricCurrentTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
-
         protected override double FemtoamperesInOneAmpere => 1e15;
 
         protected override double PicoamperesInOneAmpere => 1e12;

UnitsNet.Tests/CustomCode/ElectricFieldTests.cs

@@ -27,7 +27,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricFieldTests : ElectricFieldTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
         protected override double VoltsPerMeterInOneVoltPerMeter => 1;
     }
 }

UnitsNet.Tests/CustomCode/ElectricImpedanceTests.cs

@@ -23,7 +23,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricImpedanceTests : ElectricImpedanceTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double NanoohmsInOneOhm => 1e9;
 
         protected override double MicroohmsInOneOhm => 1e6;

UnitsNet.Tests/CustomCode/ElectricInductanceTests.cs

@@ -27,7 +27,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricInductanceTests : ElectricInductanceTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double HenriesInOneHenry => 1;
         protected override double NanohenriesInOneHenry => 1e9;
         protected override double MicrohenriesInOneHenry => 1e6;

UnitsNet.Tests/CustomCode/ElectricPotentialChangeRateTests.cs

@@ -23,7 +23,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricPotentialChangeRateTests : ElectricPotentialChangeRateTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
         protected override double KilovoltsPerHourInOneVoltPerSecond => 3.6;
         protected override double KilovoltsPerMicrosecondInOneVoltPerSecond => 1e-09;
         protected override double KilovoltsPerMinuteInOneVoltPerSecond => 6e-2;

UnitsNet.Tests/CustomCode/ElectricPotentialTests.cs

@@ -7,7 +7,6 @@ namespace UnitsNet.Tests
 {
     public class ElectricPotentialTests : ElectricPotentialTestsBase
     {
-        protected override bool SupportsSIUnitSystem => true;
         protected override double MicrovoltsInOneVolt => 1e6;
 
         protected override double MillivoltsInOneVolt => 1e3;

UnitsNet.Tests/CustomCode/ElectricReactanceTests.cs

@@ -23,7 +23,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricReactanceTests : ElectricReactanceTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double NanoohmsInOneOhm => 1e9;
 
         protected override double MicroohmsInOneOhm => 1e6;

UnitsNet.Tests/CustomCode/ElectricReactivePowerTests.cs

@@ -23,7 +23,6 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class ElectricReactivePowerTests : ElectricReactivePowerTestsBase
     {
-        protected override bool SupportsSIUnitSystem => false;
         protected override double VoltamperesReactiveInOneVoltampereReactive => 1;
 
         protected override double KilovoltamperesReactiveInOneVoltampereReactive => 1E-3;