Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

Genesis URL should be customizable #3

Open
TimoGlastra opened this issue Feb 4, 2021 · 1 comment
Open

Genesis URL should be customizable #3

TimoGlastra opened this issue Feb 4, 2021 · 1 comment
Assignees

Comments

@TimoGlastra
Copy link
Member

The genesis url is hardcoded in genesis-utils.ts. This should (optimally) be an input paramater after which the app handles downloading of the genesis, or (less optimal, but okay) be a parameter in the downloadGenesis method

async function downloadGenesis(): Promise<string> {
const url = 'http://dev.greenlight.bcovrin.vonx.io/genesis'
const response = await axios.get(url)
return response.data
}

@karimStekelenburg
Copy link
Contributor

karimStekelenburg commented Feb 4, 2021

I am aware of this. My plan is to add dotenv support so testing on multiple networks will become easier. As the proposed change will only move the hardcoded url from one place to another, I don't think this is a high priority issue (correct me if I'm wrong). Therefore I think it's best to take on this issue and add dotenv support in one go.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants