From 4320a457919ddab5a8e867fcc09648766ad01780 Mon Sep 17 00:00:00 2001 From: An Ko Date: Wed, 27 Jan 2016 18:35:00 +0100 Subject: [PATCH] Clarify what esvalid limit we're working around This does mean we're blocked on https://github.com/estools/esvalid/issues/7 if we want safety. --- src/translate.ls | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/translate.ls b/src/translate.ls index 54116ad..2293942 100644 --- a/src/translate.ls +++ b/src/translate.ls @@ -31,8 +31,10 @@ module.exports = (root-env, ast, options={}) -> |> (.map statementify) err = errors program-ast |> reject ({node}) -> - # These are valid ES6 nodes, and their errors need to be ignored. See - # https://github.com/estools/esvalid/issues/7. + # TODO Because esvalid doesn't yet support ES6 + # https://github.com/estools/esvalid/issues/7 we have to manually ignore + # errors to do with properties that have a computed key. This may miss + # some though! | node.type is \Property => node.computed and node.key?.type not in <[Identifier Literal]> | otherwise => false