Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of Write Accelerator to azure_rm_manageddisk #430

Open
AndriyDmytrenko opened this issue Feb 15, 2021 · 6 comments · May be fixed by #1808
Open

Add support of Write Accelerator to azure_rm_manageddisk #430

AndriyDmytrenko opened this issue Feb 15, 2021 · 6 comments · May be fixed by #1808
Labels
has_pr PR fixes have been made high_priority High priority question Further information is requested

Comments

@AndriyDmytrenko
Copy link

SUMMARY

Write Accelerator support would be nice to have implemented for Azure managed disks.
https://docs.microsoft.com/en-us/azure/virtual-machines/how-to-enable-write-accelerator
On the azure portal it is configurable as part of the Host Caching option, so I think the best place to add it to is attach_caching as well, or by adding another key - write_accelerator: yes/no

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

azure_rm_manageddisk

ADDITIONAL INFORMATION
azure_rm_manageddisk:
  attach_caching: write_accelerator
@Fred-sun Fred-sun added the work in In trying to solve, or in working with contributors label Feb 18, 2021
@Fred-sun
Copy link
Collaborator

@AndriyDmytrenko Thank you for asking this question. I will investigate and add this Feature! Thank you very much!

@iwt-cmd
Copy link

iwt-cmd commented Aug 11, 2023

I realize this is an older feature request but this would be very useful for our team as well. We have a large inventory of M-series VMs that have Write Accelerator enabled which we'll be managing with Ansible. Our workaround right now is using a custom execution environment with the AZ CLI installed then using "az vm update -g <rg_name> -n <vm_name> --write-accelerator <disk_lun_num>=true" via the Command module. What takes about 15-20 lines of YAML could be cut down to 1 by adding this option.

@grayzu grayzu added the high_priority High priority label Aug 14, 2023
@unkaputtbar112
Copy link

unkaputtbar112 commented Jan 17, 2025

Hi, is there any progress in this case? This issue/request is open since 2021 and since 2023 marked as high_priority.

By the way, it would go hand in hand with changes to the _info Module as well, as it shows "None" for attach_caching when Write Accelerator is enabled.

Seems like the "issue" starts deeper, as the azure.mgmt.compute (which is used by Ansible) is lacking it as well:

class CachingTypes(str, Enum, metaclass=CaseInsensitiveEnumMeta):
    """Specifies the caching requirements. Possible values are: **None,** **ReadOnly,** **ReadWrite.**
    The default values are: **None for Standard storage. ReadOnly for Premium storage**.
    """

    NONE = "None"
    READ_ONLY = "ReadOnly"
    READ_WRITE = "ReadWrite"

So the Python SDK for Azure doesn't offer a solution for this issue.
Created an issue on the Azure SDK for Python Repo:
Azure/azure-sdk-for-python#39243

@Fred-sun
Copy link
Collaborator

Fred-sun commented Jan 17, 2025

@AndriyDmytrenko @unkaputtbar112 I am very sorry for missing this problem, I will add this function as soon as possible, thank you!

@Fred-sun Fred-sun linked a pull request Jan 20, 2025 that will close this issue
@Fred-sun
Copy link
Collaborator

Fred-sun commented Jan 20, 2025

@AndriyDmytrenko @unkaputtbar112 I added parameter 'write_accelerator_enabled' in #1808, you can try it out, thank you!

@Fred-sun Fred-sun added question Further information is requested has_pr PR fixes have been made and removed work in In trying to solve, or in working with contributors labels Jan 20, 2025
@unkaputtbar112
Copy link

@Fred-sun added my tests/feedback to the #1808
Thanks for your work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has_pr PR fixes have been made high_priority High priority question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants