Pass ident value in streaming

Author: Shrews

src/ansible_runner/config/_base.py

@@ -144,7 +144,7 @@ class BaseConfig:
     fact_cache: str | None = field(metadata={MetaValues.TRANSMIT: False}, default=None)
     fact_cache_type: str = 'jsonfile'
     host_cwd: str | None = None
-    ident: str | None = field(metadata={MetaValues.TRANSMIT: False}, default=None)
+    ident: str | None = None
     json_mode: bool = False
     keepalive_seconds: int | None = field(metadata={MetaValues.TRANSMIT: False}, default=None)
     passwords: dict[str, str] | None = None
@@ -167,10 +167,22 @@ class BaseConfig:
     _CONTAINER_ENGINES = ('docker', 'podman')
 
     def __post_init__(self) -> None:
+        """
+        Completes object initialization after the Dataclass __init__() call is complete.
+
+        Finish initialization by setting other attribute defaults and normalize the path attributes
+        by setting absolute paths. Also make sure that the private_data_dir and artifact directories
+        exist, creating them if necessary.
+
+        The Runner, Transmitter, Worker and Processor objects all depend, in some manner, on this
+        path normalization being completed when they are initialized (mostly for private_data_dir).
+
+        BaseConfig and RunnerConfig both make use of the ArtifactLoader object that is created here.
+        """
         # pylint: disable=W0613
 
         self.command: list[str] = []
-        self.registry_auth_path: str
+        self.registry_auth_path: str = ""
         self.container_name: str = ""  # like other properties, not accurate until prepare is called
         if self.container_image is None:
             self.container_image = ''

test/integration/test_transmit_worker_process.py

@@ -398,8 +398,9 @@ def test_transmit_role(tmp_path, cli, project_fixtures):
     r = cli(['transmit', str(transmit_dir), '--role', 'hello_world'])
     data = json.loads(r.stdout.split('\n')[0])
     assert 'kwargs' in data
-    assert len(data['kwargs']) == 1
+    assert len(data['kwargs']) == 2
     assert 'playbook' in data['kwargs']
+    assert 'ident' in data['kwargs']
 
 
 def test_worker_without_delete_no_dir(tmp_path, cli, transmit_stream):  # pylint: disable=W0621

test/unit/config/test_runner.py

@@ -740,7 +740,9 @@ def test_containerization_settings(tmp_path, runtime, mocker):
 def test_streamable_attributes_all_defaults():
     """Test that all default values return an empty dict."""
     rc = RunnerConfig()
-    assert not rc.streamable_attributes()
+    attrs = rc.streamable_attributes()
+    assert len(attrs) == 1
+    assert 'ident' in attrs
 
 
 def test_streamable_attributes_non_default(tmp_path):
@@ -754,8 +756,10 @@ def test_streamable_attributes_non_default(tmp_path):
 
     # Don't expect private_data_dir or keepalive_seconds since they are not streamable.
     # Don't expect playbook since it is an empty value.
-    assert rc.streamable_attributes() == {
-        "host_pattern": "hostA,",
-        "json_mode": True,
-        "verbosity": 3,
-    }
+    attrs = rc.streamable_attributes()
+    assert attrs['host_pattern'] == 'hostA,'
+    assert attrs['json_mode']
+    assert attrs['verbosity'] == 3
+    assert 'private_data_dir' not in attrs
+    assert 'keepalive_seconds' not in attrs
+    assert 'playbook' not in attrs