Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBIS handling in pyaedt/src/ansys/core/circuit.py #5969

Open
2 tasks done
Ronaldo-SIPI opened this issue Mar 27, 2025 · 0 comments
Open
2 tasks done

IBIS handling in pyaedt/src/ansys/core/circuit.py #5969

Ronaldo-SIPI opened this issue Mar 27, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@Ronaldo-SIPI
Copy link

Ronaldo-SIPI commented Mar 27, 2025

Before submitting the issue

  • I have searched among the existing issues
  • I am using a Python virtual environment

Description of the bug

in
pyaedt/src/ansys/core/circuit.py
method -> create_ibis_schematic_from_pins

in line 2266 we have the issue
if ibis_tx_component_name:
cmp_tx = ibis.components[ibis_tx_component_name]
else:
cmp_tx = list(ibis.components.values())[0]
if ibis_rx_component_name:
cmp_rx = ibis.components[ibis_tx_component_name]

I try to test 2 different IBIS files (but are the same) and it fails

Steps To Reproduce

if you use the
https://examples.aedt.docs.pyansys.com/version/dev/examples/aedt_general/report/virtual_compliance.html

PCIe VC example the AMI part will not work if you specify the RX component
but in real world examples we will have 2 different ibis files and components and models

this error pops up

TypeError Traceback (most recent call last)
Cell In[23], line 1
----> 1 _, eye_curve_tx, eye_curve_rx = circuit.create_ami_schematic_from_snp(
2 input_file=touchstone_path,
3 ibis_tx_file=os.path.join(project_wp, "models", "pcieg5_16gt.ibs"),
4 ibis_rx_file=os.path.join(project_wp, "models", "pcieg5_16gt.ibs"),
5 tx_buffer_name="1p",
6 rx_buffer_name="2p",
7 tx_schematic_pins=["U1.AH24.PCIe_Gen4_RX3_P"],
8 rx_schematic_pins=["X1.A11.PCIe_Gen4_RX3_P"],
9 tx_schematic_differential_pins=["U1.AH23.PCIe_Gen4_RX3_N"],
10 rx_schematic_differentialial_pins=["X1.A12.PCIe_Gen4_RX3_N"],
11 ibis_tx_component_name="Spec_Model",
12 ibis_rx_component_name="Spec_Model",
13 use_ibis_buffer=False,
14 differential=True,
15 bit_pattern="random_bit_count=2.5e3 random_seed=1",
16 unit_interval="62.50ps",
17 use_convolution=True,
18 analyze=True,
19 design_name="AMI_RW",
20 )

TypeError: cannot unpack non-iterable bool object


ALSO
in the doc string the name tx_buffer_name and rx_buffer_name is NOT correct it must be renamed to tx_buffer_pin_name and rx_buffer_pin_name why the IBIS parser grab here the pins!!!

why???

Which Operating System are you using?

Windows

Which Python version are you using?

3.12

Installed packages

alabaster==1.0.0
annotated-types==0.7.0
ansys-api-edb==1.0.10
ansys-edb-core==0.1.9
ansys-pythonnet==3.1.0rc6
anyio==4.9.0
argon2-cffi==23.1.0
argon2-cffi-bindings==21.2.0
arrow==1.3.0
asttokens==3.0.0
async-lru==2.0.5
attrs==24.2.0
babel==2.16.0
beautifulsoup4==4.13.3
bleach==6.2.0
cattrs==24.1.2
certifi==2024.8.30
cffi==1.17.1
charset-normalizer==3.4.0
clr_loader==0.2.7.post0
colorama==0.4.6
comm==0.2.2
contourpy==1.3.1
cycler==0.12.1
debugpy==1.8.13
decorator==5.2.1
defusedxml==0.7.1
distlib==0.3.9
docutils==0.21.2
esbonio==0.16.5
executing==2.2.0
fastjsonschema==2.21.1
filelock==3.17.0
fonttools==4.56.0
fpdf2==2.8.2
fqdn==1.5.1
grpcio==1.70.0
h11==0.14.0
httpcore==1.0.7
httpx==0.28.1
idna==3.10
imagesize==1.4.1
ipykernel==6.29.5
ipython==9.0.2
ipython_pygments_lexers==1.1.1
isoduration==20.11.0
jedi==0.19.2
Jinja2==3.1.4
json5==0.10.0
jsonpointer==3.0.0
jsonschema==4.23.0
jsonschema-specifications==2024.10.1
jupyter-events==0.12.0
jupyter-lsp==2.2.5
jupyter_client==8.6.3
jupyter_core==5.7.2
jupyter_server==2.15.0
jupyter_server_terminals==0.5.3
jupyterlab==4.3.6
jupyterlab_pygments==0.3.0
jupyterlab_server==2.27.3
kiwisolver==1.4.8
lsprotocol==2023.0.1
MarkupSafe==3.0.2
matplotlib==3.10.1
matplotlib-inline==0.1.7
mistune==3.1.3
nbclient==0.10.2
nbconvert==7.16.6
nbformat==5.10.4
nest-asyncio==1.6.0
notebook==7.3.3
notebook_shim==0.2.4
numpy==2.2.4
overrides==7.7.0
packaging==24.2
pandas==2.2.3
pandocfilters==1.5.1
parso==0.8.4
pillow==11.1.0
platformdirs==4.3.6
plumbum==1.9.0
prometheus_client==0.21.1
prompt_toolkit==3.0.50
protobuf==4.25.6
psutil==7.0.0
pure_eval==0.2.3
pyaedt==0.15.1
pycparser==2.22
pydantic==2.10.6
pydantic_core==2.27.2
pyedb==0.39.1
pygls==1.3.1
Pygments==2.18.0
pyparsing==3.2.3
pyspellchecker==0.8.1
python-dateutil==2.9.0.post0
python-json-logger==3.3.0
pytz==2025.1
pywin32==310
pywinpty==2.0.15
PyYAML==6.0.2
pyzmq==26.3.0
referencing==0.35.1
requests==2.32.3
rfc3339-validator==0.1.4
rfc3986-validator==0.1.1
rpds-py==0.23.1
rpyc==6.0.1
rtree==1.4.0
scikit-rf==1.6.2
scipy==1.15.2
Send2Trash==1.8.3
setuptools==78.0.2
six==1.17.0
sniffio==1.3.1
snowballstemmer==2.2.0
soupsieve==2.6
Sphinx==8.1.3
sphinxcontrib-applehelp==2.0.0
sphinxcontrib-devhelp==2.0.0
sphinxcontrib-htmlhelp==2.1.0
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==2.0.0
sphinxcontrib-serializinghtml==2.0.0
stack-data==0.6.3
terminado==0.18.1
tinycss2==1.4.0
toml==0.10.2
tomli_w==1.2.0
tornado==6.4.2
traitlets==5.14.3
types-python-dateutil==2.9.0.20241206
typing_extensions==4.12.2
tzdata==2025.2
uri-template==1.3.0
urllib3==2.2.3
virtualenv==20.29.2
wcwidth==0.2.13
webcolors==24.11.1
webencodings==0.5.1
websocket-client==1.8.0

@Ronaldo-SIPI Ronaldo-SIPI added the bug Something isn't working label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant