Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding APDL jobs support #3111

Merged
merged 7 commits into from
May 22, 2024
Merged

Adding APDL jobs support #3111

merged 7 commits into from
May 22, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 21, 2024

As the title

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this May 21, 2024
@germa89 germa89 marked this pull request as draft May 21, 2024 08:41
@germa89 germa89 requested a review from koubaa May 21, 2024 08:42
@germa89 germa89 mentioned this pull request May 21, 2024
Closed
@germa89 germa89 changed the base branch from feat/adding-input-and-outputs to feat/pyhps-support May 22, 2024 09:47
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.85714% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 81.91%. Comparing base (4055c60) to head (00507a3).

Additional details and impacted files 
@@                  Coverage Diff                   @@
##           feat/pyhps-support    #3111      +/-   ##
======================================================
- Coverage               82.12%   81.91%   -0.22%     
======================================================
  Files                      54       54              
  Lines                    9832     9858      +26     
======================================================
  Hits                     8075     8075              
- Misses                   1757     1783      +26

@germa89
Copy link
Collaborator Author

germa89 commented May 22, 2024

Merging so everything will be reviewed together in #3091

@germa89
Copy link
Collaborator Author

germa89 commented May 22, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 marked this pull request as ready for review May 22, 2024 10:33
pyansys-ci-bot
pyansys-ci-bot approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit f23da00 into feat/pyhps-support May 22, 2024
31 checks passed
@germa89 germa89 deleted the feat/adding-apdl-input branch May 22, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@koubaa koubaa Awaiting requested review from koubaa

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@germa89 @codecov-commenter @PipKat @pyansys-ci-bot