Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring PyHPS implementation #3117

Merged
merged 13 commits into from
May 31, 2024
Merged

Refactoring PyHPS implementation #3117

merged 13 commits into from
May 31, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 21, 2024 •
edited
Loading

Going for a class based approach to make the code more reusable.

Also easier to understand, modify and extend.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 marked this pull request as draft May 21, 2024 16:39
@germa89 germa89 self-assigned this May 21, 2024
Base automatically changed from feat/adding-apdl-input to feat/pyhps-support May 22, 2024 10:33
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 0.20833% with 479 lines in your changes are missing coverage. Please review.

Project coverage is 79.74%. Comparing base (f23da00) to head (afb3a68).

Additional details and impacted files 
@@                  Coverage Diff                   @@
##           feat/pyhps-support    #3117      +/-   ##
======================================================
- Coverage               81.91%   79.74%   -2.17%     
======================================================
  Files                      54       54              
  Lines                    9858    10098     +240     
======================================================
- Hits                     8075     8053      -22     
- Misses                   1783     2045     +262

@germa89
Copy link
Collaborator Author

germa89 commented May 31, 2024

@pyansys-ci-bot LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 marked this pull request as ready for review May 31, 2024 15:29
@germa89 germa89 merged commit 0f80a47 into feat/pyhps-support May 31, 2024
30 of 33 checks passed
@germa89 germa89 deleted the feat/refactoring-to-class-based branch May 31, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@germa89 @codecov-commenter @PipKat @pyansys-ci-bot