Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image cache randomly updates #3388

Open
germa89 opened this issue Sep 9, 2024 · 2 comments
Open

Image cache randomly updates #3388

germa89 opened this issue Sep 9, 2024 · 2 comments

Comments

@germa89
Copy link
Collaborator

germa89 commented Sep 9, 2024

On #3386 the image cache got updated, but "in theory" no plotting dependencies were updated.

Well... in that PR, the visualizer was updated. Later I remove that update.

So it seems we are not pinging properly the important dependencies for testing. Since pyvista started to be a "subdependency" (dependency of a dependency, visualizer), I have seen this twice.... I did fix it first time in: https://github.com/ansys/pymapdl/pull/3371/files

I believe I should add pyvista as a test dependency so we make sure we are getting the same stuff everytime.

@germa89
Copy link
Collaborator Author

germa89 commented Sep 9, 2024

Pinging @AlejandroFernandezLuces for feedback.

@AlejandroFernandezLuces
Copy link
Contributor

Hmm that's an interesting problem... If I'm understanding the issue right, I would separate the visualizer to update individually instead of being included in a group. Since updating this involves more changes than just bumping the dependency, I think it being independent is justified and it solves this issue.

In any case I'm not sure why the cache update is being triggered there. It seems that the update is somehow linked to the group to the single dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants