Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: externalise 'report' features to module #3511

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 24, 2024

Description

As the title.

Issue linked

Related to #3491

Checklist

@germa89 germa89 requested a review from a team as a code owner October 24, 2024 11:55
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team October 24, 2024 11:55
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Oct 24, 2024
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.37%. Comparing base (279cbba) to head (c44fa35).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3511   +/-   ##
=======================================
  Coverage   82.36%   82.37%           
=======================================
  Files          57       58    +1     
  Lines       10004    10006    +2     
=======================================
+ Hits         8240     8242    +2     
  Misses       1764     1764           

@germa89 germa89 changed the title refactor: externalise the 'report' features to another file refactor: externalise 'report' features to module Oct 25, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Oct 25, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) October 25, 2024 11:39
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 76b7cf2 into main Oct 25, 2024
62 of 63 checks passed
@germa89 germa89 deleted the refactor/externalise-report-classes branch October 25, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants