Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: temporary skipping attrs license check #3624

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 18, 2024

Description

As the title.

Issue linked

Related issues ansys/actions#658

Checklist

@germa89 germa89 requested a review from a team as a code owner December 18, 2024 09:53
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Dec 18, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Dec 18, 2024

@pyansys-ci-bot LGTM

We do not need to wait for the PyMAPDL testing since this change only affects the smoke tests

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 59051c5 into main Dec 18, 2024
55 of 57 checks passed
@germa89 germa89 deleted the ci/temporaly-skiping-attrs-license-check branch December 18, 2024 10:07
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.00%. Comparing base (b5e482a) to head (8ab569a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3624      +/-   ##
==========================================
- Coverage   87.01%   87.00%   -0.01%     
==========================================
  Files         187      187              
  Lines       14661    14661              
==========================================
- Hits        12757    12756       -1     
- Misses       1904     1905       +1     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants