Merge pull request #557 from antvis/fix-repaint-remove-halo

fix guide.repaint will remove halo
antvis · Apr 18, 2019 · 99b12fc · 99b12fc
2 parents 9943e70 + 8febbba
commit 99b12fc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/interaction/pie-select.js b/src/interaction/pie-select.js
@@ -106,8 +106,6 @@ class PieSelect extends Interaction {
     }
     const { x, y } = Util.createEvent(ev, chart);
 
-    this.halo && this.halo.remove(true);
-
     const records = chart.getSnapRecords({ x, y });
     if (!records.length) {
       this.selected = false;
@@ -128,6 +126,7 @@ class PieSelect extends Interaction {
       this.lastShape = null;
       this.selected = false;
     } else {
+      this.halo && this.halo.remove(true);
       this._selectedShape(selectedShape);
     }
 

diff --git a/test/unit/interaction/pie-select-spec.js b/test/unit/interaction/pie-select-spec.js
@@ -227,7 +227,7 @@ describe('Pie-Select', function() {
       expect(interaction.selectedShape).not.to.be.null;
       expect(interaction.selectedShape.get('origin')._origin).to.eql({ name: '机器之血', percent: 0.18, a: '1' });
       expect(interaction.halo).not.to.be.undefined;
-      expect(interaction.halo.get('destroyed')).to.be.true;
+      expect(interaction.halo.get('destroyed')).to.be.false;
       chart.destroy();
       done();
     }, 300);