Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unified-scheduler can not be built using nightly rustc due to polyfill API mismatch #5198

Open
alexpyattaev opened this issue Mar 8, 2025 · 1 comment
Assignees

Comments

@alexpyattaev
Copy link

alexpyattaev commented Mar 8, 2025

Problem

https://crates.io/crates/vec_extract_if_polyfill is outdated and no longer matches the API offered in nightly rust.
For reference the new API includes additional range argument https://doc.rust-lang.org/std/vec/struct.Vec.html#method.extract_if

This means that unified-scheduler can no longer be built using nightly rustc

// Use the still-unstable Vec::extract_if() even on stable rust toolchain by

Proposed Solution

Maybe just copy the implementation from the library into our sources until feature stabilizes?

@ifiokjr
Copy link

ifiokjr commented Mar 17, 2025

I didn't see this before creating #5322.

I've also opened a pull request for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants