Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV: Use core::error::Error instead of std::error::Error #81

Open
joncinque opened this issue Mar 19, 2025 · 0 comments
Open

MSRV: Use core::error::Error instead of std::error::Error #81

joncinque opened this issue Mar 19, 2025 · 0 comments

Comments

@joncinque
Copy link
Collaborator

Problem

A lot of places in the SDK use the std feature to enable an implementation of std::error::Error, but this isn't needed because the Error trait was moved down to `core.

As mentioned at #12 (comment) though, using core::error::Error instead of std::error::Error requires an MSRV bump to 1.81.

Proposed Solution

Whenever we want to make an MSRV bump, let's remove the std::error::Error usage everywhere in favor of core::error::Error. Maybe we can include that whenever we bump the edition to 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant