MySQL testing

Author: aodin

.travis.yml

@@ -1,5 +1,6 @@
 language: go
 sudo: false
 before_script:
-  - psql -c 'create database travis_ci_test;' -U postgres
-  - psql -c 'CREATE EXTENSION IF NOT EXISTS postgis; CREATE EXTENSION IF NOT EXISTS "uuid-ossp"; CREATE EXTENSION IF NOT EXISTS "pg_trgm";' -U postgres -d travis_ci_test
+  - psql -c 'create database sol_test;' -U postgres
+  - psql -c 'CREATE EXTENSION IF NOT EXISTS postgis; CREATE EXTENSION IF NOT EXISTS "uuid-ossp"; CREATE EXTENSION IF NOT EXISTS "pg_trgm";' -U postgres -d sol_test
+  - mysql -e 'create database sol_test;'

mysql/README.md

@@ -0,0 +1,28 @@
+# MySQL
+
+The MySQL dialect uses the [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) driver, which [passes the compatibility test suite](https://github.com/golang/go/wiki/SQLDrivers).
+
+By default, this MySQL dialect will parse `DATE` and `DATETIME` columns into `[]byte` or `string` types. Support for `time.Time` must be explicitly enabled by adding the `parseTime=true` parameter to the connection string.
+
+### Testing
+
+A valid MySQL connection string should be set on the environmental variable `SOL_TEST_MYSQL`. An example:
+
+    user:pass@tcp(host:port)/db?parseTime=true
+
+This variable can be given inline:
+
+    SOL_TEST_MYSQL="user:pass@tcp(host:port)/db?parseTime=true" go test -run=TestMySQL
+
+If the environmental variable is not given, it will default to a [Travis CI](https://docs.travis-ci.com/user/database-setup/#MySQL) connection string, which will likely panic on your local system.
+
+#### Docker
+
+Docker hub provides an [official MySQL image](https://hub.docker.com/_/mysql/). A container can be started with:
+
+    docker run -p 3306:3306 --name mysql -e "MYSQL_ROOT_PASSWORD=" -e "MYSQL_ALLOW_EMPTY_PASSWORD=yes" -e "MYSQL_DATABASE=sol_test" -d mysql:latest
+
+
+Tests can then be running by supplying the host IP of the default Docker in the environmental variable credential string, such as:
+
+    SOL_TEST_MYSQL="root@tcp(host:3306)/sol_test?parseTime=true" go test

mysql/mysql_test.go

@@ -0,0 +1,40 @@
+package mysql
+
+import (
+	"os"
+	"sync"
+	"testing"
+
+	_ "github.com/go-sql-driver/mysql"
+
+	"github.com/aodin/sol"
+)
+
+const travisCI = "root@tcp(127.0.0.1:3306)/sol_test?parseTime=true"
+
+var conn *sol.DB
+var once sync.Once
+
+// getConn returns a MySQL connection pool
+func getConn(t *testing.T) *sol.DB {
+	// Check if an ENV VAR has been set, otherwise, use travis
+	credentials := os.Getenv("SOL_TEST_MYSQL")
+	if credentials == "" {
+		credentials = travisCI
+	}
+
+	once.Do(func() {
+		var err error
+		if conn, err = sol.Open("mysql", credentials); err != nil {
+			t.Fatalf("Failed to open connection: %s", err)
+		}
+		conn.SetMaxOpenConns(20)
+	})
+	return conn
+}
+
+func TestMySQL(t *testing.T) {
+	conn := getConn(t)
+	defer conn.Close()
+	sol.IntegrationTest(t, conn)
+}

tester.go

@@ -6,8 +6,10 @@ import (
 	"runtime"
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/aodin/sol/dialect"
+	"github.com/aodin/sol/types"
 )
 
 // callerInfo returns a string containing the file and line number of the
@@ -104,3 +106,102 @@ func (t *tester) SQL(stmt Compiles, expect string, ps ...interface{}) {
 func NewTester(t *testing.T, d dialect.Dialect) *tester {
 	return &tester{t: t, dialect: d}
 }
+
+// IntegrationTest runs a large, neutral dialect test
+func IntegrationTest(t *testing.T, conn *DB) {
+	// Perform all tests in a transaction
+	// TODO What features should be testing outside of a transaction?
+	tx, err := conn.Begin()
+	if err != nil {
+		t.Fatalf("Creating a new transaction should not error: %s", err)
+	}
+	defer tx.Rollback()
+
+	// CREATE TABLE
+	// TODO foreign keys
+	testusers := Table("testusers",
+		Column("id", types.Integer()),
+		Column("email", types.Varchar().Limit(256).NotNull()),
+		Column("is_admin", types.Boolean().NotNull()),
+		Column("created_at", types.Timestamp()),
+		PrimaryKey("id"),
+		Unique("email"),
+	)
+
+	type testuser struct {
+		ID        int64
+		Email     string
+		IsAdmin   bool
+		CreatedAt time.Time
+	}
+
+	if err = tx.Query(testusers.Create()); err != nil {
+		t.Fatalf("CREATE TABLE should not error: %s", err)
+	}
+
+	// INSERT by struct
+	// Truncate the time.Time field to avoid significant digit errors
+	admin := testuser{
+		ID:        1,
+		Email:     "[email protected]",
+		IsAdmin:   true,
+		CreatedAt: time.Now().UTC().Truncate(time.Second),
+	}
+
+	if err = tx.Query(testusers.Insert().Values(admin)); err != nil {
+		t.Fatalf("INSERT should not fail %s", err)
+	}
+
+	// SELECT
+	var selected testuser
+	if err = tx.Query(
+		testusers.Select().Where(testusers.C("id").Equals(admin.ID)),
+		&selected,
+	); err != nil {
+		t.Fatalf("SELECT should not fail: %s", err)
+	}
+
+	if selected != admin {
+		t.Errorf(
+			"Unequal testusers: have %+v, want %+v",
+			selected, admin,
+		)
+	}
+
+	// UPDATE
+	if err = tx.Query(
+		testusers.Update().Values(
+			Values{"is_admin": false},
+		).Where(testusers.C("id").Equals(admin.ID)),
+	); err != nil {
+		t.Fatalf("UPDATE should not fail: %s", err)
+	}
+
+	var updated testuser
+	if err = tx.Query(
+		testusers.Select().Where(testusers.C("id").Equals(admin.ID)),
+		&updated,
+	); err != nil {
+		t.Fatalf("SELECT should not fail: %s", err)
+	}
+
+	selected.IsAdmin = false
+	if updated != selected {
+		t.Errorf(
+			"Unequal testusers: have %+v, want %+v",
+			updated, selected,
+		)
+	}
+
+	// DELETE
+	if err = tx.Query(
+		testusers.Delete().Where(testusers.C("email").Equals(admin.Email)),
+	); err != nil {
+		t.Fatalf("DELETE should not fail: %s", err)
+	}
+
+	// DROP TABLE
+	if err = tx.Query(testusers.Drop()); err != nil {
+		t.Fatalf("DROP TABLE should not fail %s", err)
+	}
+}