-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test for multipart uploads with checksums #6794
base: main
Are you sure you want to change the base?
Conversation
So there are a couple of issues with how multi-part upload is implemented:
So this means that we need to keep the checksums in the |
5537c29
to
74f0c9c
Compare
I'm not sure about this, an AWS specific detail now leaks into the public trait for all stores... It also is not immediately obvious when the checksums are needed or not... I think this needs a bit more thought, I'll try to find some time in the next few weeks |
FWIW: I verified in the new tests we are now writing the checksums at the correct times for when the digest functionality is enabled. Now I am just trying to get the original tests working for when it isn't. |
Which issue does this PR close?
Closes #6793.
Rationale for this change
Described in issue
What changes are included in this PR?
A failing test
Are there any user-facing changes?
Multipart uploads fail