deduplicate variadic buffers in MutableArrayData::extend for ByteView arrays #6808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
Nov 27, 2024
| _ => vec![], | ||
| let (variadic_data_buffers, buffer_to_idx) = match &data_type { | ||
| DataType::BinaryView | DataType::Utf8View => { | ||
| let mut buffer_to_idx = HashMap::new(); |
There was a problem hiding this comment.
I wonder if building a hashmap / vec would be overly expensive (though we would need to run benchmarks to be sure)
There was a problem hiding this comment.
happy to run benchmarks, any particular in mind or should I create one with criterion specific to this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
MutableArrayData adds all variadic buffers from input arrays together, potentially duplicating the same buffers in the output array.
What changes are included in this PR?
extendnow checks if the same buffer is added from some other input array and changes the views to be appended to point to the new deduplicated buffer indicesAre there any user-facing changes?