GH-45605: [R][C++] Fix identifier ... preceded by whitespace warnings

[jonkeane]

Rationale for this change

Fix warnings, pass on CRAN

What changes are included in this PR?

Removing some whitespace

Are these changes tested?

Yes

Are there any user-facing changes?

No, other than being releasable on CRAN

• GitHub Issue: [R][C++] Fix identifier ... preceded by whitespace warnings #45605

[jonkeane]

@github-actions crossbow submit test-r-linux-as-cran

[github-actions]

Revision: c81bfb0

Submitted crossbow builds: ursacomputing/crossbow @ actions-4e0e69ed96

Task	Status
test-r-linux-as-cran

[jonkeane]

@github-actions crossbow submit test-r-linux-as-cran

[github-actions]

Revision: 27b318c

Submitted crossbow builds: ursacomputing/crossbow @ actions-72b7eea56e

Task	Status
test-r-linux-as-cran

[jonkeane]

The clang20 job is failing due to not having latex (cf r-hub/containers#23) which we can ignore in this case, but won't be able to add it to the matrix if we need to ignore it — that's ok though, we just need to check this. It doesn't reproduce the failure we saw on CRAN but the clang20 image is out of date from r-hub. I pushed r-hub/containers#89 upstream to update the clang20 build, and then once that's failing can see if we get that same error.

[jonkeane]

@github-actions crossbow submit test-r-linux-as-cran

[github-actions]

Failed to render template `r/github.linux.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/13486720494

[jonkeane]

@github-actions crossbow submit test-r-linux-as-cran

[github-actions]

Failed to render template `r/github.linux.cran.yml` with UndefinedError: 'matrix' is undefined
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/13486744445

[jonkeane]

@github-actions crossbow submit test-r-linux-as-cran

[github-actions]

Revision: 1f5438d

Submitted crossbow builds: ursacomputing/crossbow @ actions-c4c3a36e7c

Task	Status
test-r-linux-as-cran

[jonkeane]

@github-actions crossbow submit test-r-linux-as-cran

clang20 has been updated, so this should run with a newer build (and hopefully also will fail)

[github-actions]

Revision: 56c2e9e

Submitted crossbow builds: ursacomputing/crossbow @ actions-f272630e4b

Task	Status
test-r-linux-as-cran

[jonkeane]

@github-actions crossbow submit test-r-linux-as-cran

And now with the fix?

[github-actions]

Revision: 03c12f1

Submitted crossbow builds: ursacomputing/crossbow @ actions-ba7fbc8d5c

Task	Status
test-r-linux-as-cran

[jonkeane]

^^^ Worked, the failures that persist are due to cpp11 which is resolved with r-lib/cpp11#448

[amoeba]

Thanks! I'll merge this in a sec here.

[jonkeane]

(It's totally ok that this is merged), but we might want to pull dev of cpp11 with r-lib/cpp11#448 when it merges in order for the new clang 20 job to pass cleanly

[amoeba]

👍. I filed #45616 for that.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a01a812.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.