Skip to content

Add tracing regression smoke tests #15672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geoffreyclaude opened this issue Apr 10, 2025 · 1 comment · Fixed by #15673
Closed

Add tracing regression smoke tests #15672

geoffreyclaude opened this issue Apr 10, 2025 · 1 comment · Fixed by #15673
Assignees
Labels
enhancement New feature or request

Comments

@geoffreyclaude
Copy link
Contributor

geoffreyclaude commented Apr 10, 2025

Is your feature request related to a problem or challenge?

#14547 introduced the JoinSetTracer trait for tracing context propagation in spawned tasks, but was lacking integration tests. This means that any change to the core task spawning mechanism inside DataFusion, susceptible to break the tracing functionality, would go unnoticed.

Describe the solution you'd like

Unit tests should fail if the JoinSetTracer integration does not work as expected anymore. As a comprehensive complete test suite would pretty much require a full code coverage, a simple "smoke test" that fails if the JoinSetTracer cannot be properly registered should be a good first step.

Describe alternatives you've considered

Additional context

@ashdnazg in #15653 modified task spawning, and it was only by luck that @gabotechs caught the possible regression in #15653 (comment) .

@geoffreyclaude geoffreyclaude added the enhancement New feature or request label Apr 10, 2025
@geoffreyclaude
Copy link
Contributor Author

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant